-
Notifications
You must be signed in to change notification settings - Fork 12.8k
allow tsserver to be restarted via its public API #13059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I actually have set this up because the problem is so rampant {
"key": "ctrl+shift+l",
"command": "workbench.action.reloadWindow"
} |
This sounds like a bug. we would appreciate it if you can share some repro steps/project samples to help us diagnose the issue. |
@Aleksey-Bykov can you please enable tracing for tsserver in VSCode via |
|
looks like the same symptoms of #10735. do you see this with all projects, or just one? |
@Aleksey-Bykov is this still a problem? |
yes, it still hangs any time i open javascript file
…On Feb 13, 2017 6:59 PM, "Mohamed Hegazy" ***@***.***> wrote:
@Aleksey-Bykov <https://github.com/aleksey-bykov> is this still a problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13059 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5PzWbjkV2Hi5q7ikke-GF3h_gUNlp7ks5rcO5ugaJpZM4LSGbU>
.
|
Can you share a repro project? |
no, it's not mine, and the client is very serious about not showing it to anyone |
Do you see this on other projects? Anything special stands out to you about this project? Do you see any exceptions in the log? |
to clear it up, i see this problem when i open a javascript emitted by the typescript compiler i cannot see it in my own personal project that uses javascript along side with typescript, but i see in at the work project, i think i might know the reason, there are a bunch of heavy javascript libraries like knockout, jquery, jqx, etc in a close vicinity of the typescript generated javascript files, i think what happens is that when i open a generated javascript file these libs get loaded via dependencies and it's just too much for the language service to handle while coding typescript there is no such problem because instead of the implementation we work with definitions which are several times shorter although it's the speculation i don't have a better explanation, so i blame heavy javascript libs |
just checked my theory, i think i found it i have var hey = 'hey';
alert(hey); when i put it to my
when i put it outside of src at the same level where the heavy js libs sit, it hangs:
|
VS Code's from the screen shots above, we are just loading too many files, we have added some checks for detecting too many files cases and handling them gracefully. but enumerating directories and parsing JS files still take resources. our recommendation is to add excludes to tsconfig. |
every time i open a JS file in my TS project in VSCode, i stop getting any help from tsserver, no autocomplete/hints/anything
i have to close VSCode and start it over, it would be nice to tell tsserver to restart itself instead
The text was updated successfully, but these errors were encountered: