-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Bug in transpileModule in ts 2.9.1 #24729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mhegazy - my apologies, I said I had tested with ts@next, and I did, but I think webpack's cache-loader incorrectly served me old (wrong) results. ts@next does indeed work. Any idea when 2.9.2 will be out? You said next week - I don't suppose there's any chance it could be sooner? |
thanks for confirming. |
I have a reproducible project where even the latest version of TypeScript available did not work. See TypeStrong/ts-loader#787 (comment) |
here is the file text: import { Options } from "./Options";
import { Parent } from "./Parent";
export class Child extends Parent
{
constructor (name: string)
{
super ("1", name, new Options ());
}
} |
So thanks for the repro. |
Fixed by #24802 |
@mhegazy you guys are awesome. Any idea when 2.9.2 will be out? |
Original plan is to get it out Wednesday. we are still looking at one final issue. so it could be Thursday. but barring any unforeseen circumstances, it should be out this week. |
thanks a ton! |
Please try to reproduce the issue with
typescript@next
. It may have already been fixed.TypeScript Version: 3.0.0-dev.20180606 - still fails
Search terms you tried before logging this (so others can find this issue more easily)
transpileModule, 2.9.1
Code
No publicly available repro
This issue was originally raised here
TypeStrong/ts-loader#787 (comment)
until it was realized this was a bug with TS itself. It seems transpileModule is dropping valid, needed imports, which is creating runtime errors
Expected behavior:
Used imports will not be dropped
Actual behavior:
They're dropped
Playground Link:
Related Issues:
The text was updated successfully, but these errors were encountered: