Visit super arguments even when no signature exists #24591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Jun 1, 2018
|
Please port to release-2.9 as well |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Jun 1, 2018
weswigham
added a commit
that referenced
this pull request
Jun 2, 2018
This was referenced Jun 2, 2018
mhegazy
reviewed
Jun 8, 2018
| @@ -18678,6 +18678,7 @@ namespace ts { | |||
| if (node.expression.kind === SyntaxKind.SuperKeyword) { | |||
| const superType = checkSuperExpression(node.expression); | |||
| if (isTypeAny(superType)) { | |||
| forEach(node.arguments, checkExpression); // Still visit arguments so they get marked for visibility, etc | |||
There was a problem hiding this comment.
@weswigham this should be forEach(node.arguments, n=>{checkExpression(n);});
the return value from checkExpression is short-circuiting after the first argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24551