Skip to content

Doc comment has trailing space #25916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jul 25, 2018 · 3 comments
Closed

Doc comment has trailing space #25916

ghost opened this issue Jul 25, 2018 · 3 comments
Labels
Bug A bug in TypeScript Domain: JSDoc Relates to JSDoc parsing and type generation Domain: Quick Info e.g. hover text, tool-tips, and tooltips. Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 3.1

Comments

@ghost
Copy link

ghost commented Jul 25, 2018

TypeScript Version: master

Code

/// <reference path='fourslash.ts'/>

// @Filename: quickInfoJsDocTags.ts
/////** Doc */
////const /**/x = 0;

verify.quickInfoAt("", "const x: 0", "Doc");

Expected behavior:

Test passes.

Actual behavior:

Test fails. Doc comment is actually "Doc ".
@ghost ghost added Bug A bug in TypeScript Domain: JSDoc Relates to JSDoc parsing and type generation Domain: Quick Info e.g. hover text, tool-tips, and tooltips. labels Jul 25, 2018
@mhegazy mhegazy added the Help Wanted You can do this label Jul 25, 2018
@tschaub tschaub mentioned this issue Jul 27, 2018
Merged
@tschaub
Copy link
Contributor

tschaub commented Jul 27, 2018

I'm interested in helping out with the JSDoc support in TypeScript. Let me know if #26029 looks like a reasonable approach to this issue. Thanks!

@ghost
Copy link
Author

ghost commented Jul 28, 2018

Related: #21123

@mhegazy mhegazy added this to the TypeScript 3.1 milestone Jul 28, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jul 28, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 28, 2018

thanks @tschaub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: JSDoc Relates to JSDoc parsing and type generation Domain: Quick Info e.g. hover text, tool-tips, and tooltips. Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 3.1
Development

No branches or pull requests
2 participants
@tschaub @mhegazy