-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Remove trailing whitespace from JSDoc comments #26029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was initially only running Update - I've modified some additional test cases to reflect the lack of trailing whitespace. I'll keep going after getting confirmation that there is agreement about this change. |
@@ -0,0 +1,7 @@ | |||
/// <reference path='fourslash.ts'/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test is probably not necessary given the number of other tests updated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but I thought a test with multiple trailing spaces would make sense.
//// render() { | ||
//// <div /*1*/ ></div>; | ||
//// <div /*2*/ /> | ||
//// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change was due to mixed line endings in the file. I can remove this part of the change if needed.
I've updated the remaining tests to reflect the new behavior. Let me know if you think the addition of the |
This removes trailing whitespace from JSDoc comments. I'll add additional tests after confirming that this is going in a direction you agree with.
Fixes #25916