Skip to content

Performance regression in #32582 #36562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amcasey opened this issue Jan 31, 2020 · 3 comments
Closed

Performance regression in #32582 #36562

amcasey opened this issue Jan 31, 2020 · 3 comments
Assignees
@ahejlsberg
Labels
Domain: Performance Reports of unusually slow behavior Needs Investigation This issue needs a team member to investigate its status. Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@amcasey
Copy link
Member

amcasey commented Jan 31, 2020 •
edited
Loading

The extra work done in #32582 is valuable, but maybe it doesn't need to be so expensive.

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

  • 10-run avg on d00056f: 28,858ms
  • 10-run avg on 480b739: 31,001ms (7% slower)

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.
@amcasey amcasey added Needs Investigation This issue needs a team member to investigate its status. Domain: Performance Reports of unusually slow behavior labels Jan 31, 2020
@amcasey
Copy link
Member Author

amcasey commented Feb 1, 2020

FYI @sandersn

@amcasey amcasey mentioned this issue Feb 3, 2020
Closed
@amcasey
Copy link
Member Author

amcasey commented Feb 7, 2020

@ahejlsberg You seem to be on a roll with clawing back these perf regressions, so I thought I'd bring this one other large regression to your attention. 😉

@weswigham weswigham mentioned this issue Feb 7, 2020
Closed
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.6.0 milestone Nov 3, 2021
@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label Feb 1, 2023
@ahejlsberg
Copy link
Member

I'm closing this. Our performance on material-ui has substantially improved since this issue was opened. Specifically, check time for the OP repo was ~10s with v3.6 and is now ~7.2s with v5.1.

@ahejlsberg ahejlsberg removed this from the TypeScript 5.1.0 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahejlsberg ahejlsberg

Labels
Domain: Performance Reports of unusually slow behavior Needs Investigation This issue needs a team member to investigate its status. Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DanielRosenwasser @ahejlsberg @RyanCavanaugh @amcasey