Cache multiple relationship comparisons based on one relationship comparison result

[weswigham]

Maybe helps with #36562, we'll see.

[weswigham]

@typescript-bot perf test this

[typescript-bot]

Heya @weswigham, I've started to run the perf test suite on this PR at 1b46016. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36667

Metric	master	36667	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	356,858k (± 0.01%)	365,907k (± 0.02%)	+9,049k (+ 2.54%)	365,738k	366,108k
Parse Time	1.61s (± 0.50%)	1.62s (± 0.37%)	+0.00s (+ 0.25%)	1.61s	1.63s
Bind Time	0.89s (± 0.95%)	0.88s (± 0.63%)	-0.01s (- 0.79%)	0.87s	0.89s
Check Time	4.67s (± 0.44%)	4.73s (± 0.52%)	+0.06s (+ 1.26%)	4.66s	4.77s
Emit Time	5.22s (± 0.25%)	5.24s (± 1.00%)	+0.02s (+ 0.36%)	5.10s	5.37s
Total Time	12.40s (± 0.23%)	12.47s (± 0.57%)	+0.07s (+ 0.58%)	12.30s	12.60s
Monaco - node (v10.16.3, x64)
Memory used	364,682k (± 0.02%)	378,700k (± 0.01%)	+14,018k (+ 3.84%)	378,611k	378,877k
Parse Time	1.25s (± 0.66%)	1.25s (± 0.52%)	-0.00s (- 0.16%)	1.24s	1.27s
Bind Time	0.78s (± 0.48%)	0.77s (± 0.44%)	-0.00s (- 0.26%)	0.77s	0.78s
Check Time	4.68s (± 0.70%)	4.79s (± 0.32%)	+0.10s (+ 2.22%)	4.75s	4.81s
Emit Time	2.90s (± 0.77%)	2.91s (± 0.59%)	+0.01s (+ 0.17%)	2.86s	2.94s
Total Time	9.61s (± 0.45%)	9.72s (± 0.24%)	+0.11s (+ 1.10%)	9.67s	9.76s
TFS - node (v10.16.3, x64)
Memory used	324,299k (± 0.07%)	327,621k (± 0.02%)	+3,323k (+ 1.02%)	327,493k	327,775k
Parse Time	0.94s (± 0.52%)	0.94s (± 0.50%)	-0.00s (- 0.11%)	0.94s	0.96s
Bind Time	0.75s (± 1.54%)	0.75s (± 0.69%)	+0.00s (+ 0.54%)	0.74s	0.76s
Check Time	4.23s (± 0.38%)	4.26s (± 0.28%)	+0.03s (+ 0.69%)	4.24s	4.29s
Emit Time	3.01s (± 0.76%)	3.01s (± 0.64%)	+0.00s (+ 0.03%)	2.96s	3.05s
Total Time	8.93s (± 0.43%)	8.97s (± 0.30%)	+0.04s (+ 0.41%)	8.91s	9.02s
Angular - node (v12.1.0, x64)
Memory used	332,632k (± 0.07%)	340,595k (± 0.12%)	+7,963k (+ 2.39%)	339,686k	341,101k
Parse Time	1.57s (± 0.54%)	1.57s (± 0.31%)	-0.00s (- 0.19%)	1.56s	1.58s
Bind Time	0.86s (± 1.10%)	0.88s (± 0.91%)	+0.01s (+ 1.50%)	0.87s	0.90s
Check Time	4.62s (± 0.80%)	4.66s (± 0.82%)	+0.04s (+ 0.98%)	4.59s	4.75s
Emit Time	5.41s (± 0.57%)	5.43s (± 1.14%)	+0.02s (+ 0.41%)	5.33s	5.57s
Total Time	12.46s (± 0.47%)	12.53s (± 0.78%)	+0.08s (+ 0.62%)	12.37s	12.73s
Monaco - node (v12.1.0, x64)
Memory used	344,551k (± 0.02%)	356,624k (± 0.02%)	+12,073k (+ 3.50%)	356,533k	356,761k
Parse Time	1.22s (± 0.67%)	1.21s (± 0.62%)	-0.01s (- 0.57%)	1.20s	1.23s
Bind Time	0.75s (± 0.80%)	0.75s (± 1.35%)	+0.00s (+ 0.13%)	0.73s	0.78s
Check Time	4.54s (± 0.35%)	4.65s (± 0.52%)	+0.11s (+ 2.43%)	4.59s	4.69s
Emit Time	2.94s (± 0.61%)	2.96s (± 0.72%)	+0.02s (+ 0.61%)	2.92s	3.00s
Total Time	9.44s (± 0.31%)	9.56s (± 0.36%)	+0.12s (+ 1.30%)	9.50s	9.64s
TFS - node (v12.1.0, x64)
Memory used	306,384k (± 0.02%)	309,376k (± 0.02%)	+2,993k (+ 0.98%)	309,267k	309,475k
Parse Time	0.94s (± 0.66%)	0.94s (± 0.63%)	-0.00s (- 0.32%)	0.92s	0.95s
Bind Time	0.70s (± 0.53%)	0.70s (± 0.52%)	-0.00s (- 0.14%)	0.70s	0.71s
Check Time	4.17s (± 0.44%)	4.21s (± 0.52%)	+0.04s (+ 0.98%)	4.13s	4.24s
Emit Time	3.07s (± 0.63%)	3.08s (± 0.73%)	+0.02s (+ 0.59%)	3.02s	3.13s
Total Time	8.88s (± 0.38%)	8.93s (± 0.41%)	+0.06s (+ 0.63%)	8.85s	9.00s
Angular - node (v8.9.0, x64)
Memory used	351,823k (± 0.01%)	361,218k (± 0.01%)	+9,395k (+ 2.67%)	361,083k	361,322k
Parse Time	2.10s (± 0.54%)	2.12s (± 0.46%)	+0.02s (+ 1.10%)	2.10s	2.14s
Bind Time	0.92s (± 0.64%)	0.93s (± 0.60%)	+0.01s (+ 0.87%)	0.92s	0.94s
Check Time	5.46s (± 0.66%)	5.52s (± 0.49%)	+0.07s (+ 1.23%)	5.47s	5.57s
Emit Time	6.24s (± 0.36%)	6.28s (± 0.75%)	+0.04s (+ 0.71%)	6.14s	6.38s
Total Time	14.71s (± 0.25%)	14.86s (± 0.47%)	+0.15s (+ 0.99%)	14.66s	15.02s
Monaco - node (v8.9.0, x64)
Memory used	362,939k (± 0.01%)	377,777k (± 0.01%)	+14,838k (+ 4.09%)	377,691k	377,855k
Parse Time	1.56s (± 0.43%)	1.56s (± 0.43%)	+0.00s (+ 0.00%)	1.55s	1.58s
Bind Time	0.95s (± 0.49%)	0.94s (± 0.63%)	-0.01s (- 0.63%)	0.93s	0.96s
Check Time	5.39s (± 1.25%)	5.61s (± 0.70%)	+0.22s (+ 4.06%)	5.50s	5.68s
Emit Time	3.30s (± 3.17%)	3.04s (± 0.68%)	-0.26s (- 7.96%)	2.99s	3.09s
Total Time	11.21s (± 0.55%)	11.16s (± 0.36%)	-0.05s (- 0.44%)	11.08s	11.26s
TFS - node (v8.9.0, x64)
Memory used	323,541k (± 0.02%)	326,997k (± 0.01%)	+3,456k (+ 1.07%)	326,913k	327,070k
Parse Time	1.26s (± 0.44%)	1.26s (± 0.41%)	-0.00s (- 0.08%)	1.25s	1.27s
Bind Time	0.75s (± 0.65%)	0.75s (± 0.77%)	-0.00s (- 0.13%)	0.74s	0.77s
Check Time	4.82s (± 0.56%)	4.82s (± 0.58%)	-0.00s (- 0.06%)	4.77s	4.88s
Emit Time	3.20s (± 0.73%)	3.19s (± 0.35%)	-0.01s (- 0.16%)	3.18s	3.22s
Total Time	10.04s (± 0.41%)	10.03s (± 0.35%)	-0.01s (- 0.11%)	9.97s	10.11s
Angular - node (v8.9.0, x86)
Memory used	200,058k (± 0.02%)	205,044k (± 0.03%)	+4,987k (+ 2.49%)	204,924k	205,157k
Parse Time	2.04s (± 1.23%)	2.04s (± 0.43%)	+0.00s (+ 0.20%)	2.02s	2.06s
Bind Time	1.05s (± 0.85%)	1.06s (± 0.61%)	+0.01s (+ 1.15%)	1.04s	1.07s
Check Time	4.97s (± 0.70%)	5.02s (± 0.55%)	+0.05s (+ 1.11%)	4.95s	5.09s
Emit Time	6.06s (± 1.14%)	6.07s (± 1.44%)	+0.01s (+ 0.10%)	5.90s	6.27s
Total Time	14.11s (± 0.61%)	14.19s (± 0.62%)	+0.08s (+ 0.56%)	13.99s	14.38s
Monaco - node (v8.9.0, x86)
Memory used	203,746k (± 0.02%)	211,627k (± 0.02%)	+7,881k (+ 3.87%)	211,529k	211,753k
Parse Time	1.60s (± 0.55%)	1.60s (± 0.66%)	-0.00s (- 0.19%)	1.59s	1.64s
Bind Time	0.77s (± 1.35%)	0.77s (± 0.76%)	-0.01s (- 0.65%)	0.76s	0.78s
Check Time	5.19s (± 1.98%)	5.48s (± 0.47%)	+0.29s (+ 5.69%)	5.44s	5.54s
Emit Time	3.13s (± 2.72%)	2.84s (± 1.90%)	-0.29s (- 9.42%)	2.71s	3.02s
Total Time	10.69s (± 0.42%)	10.68s (± 0.42%)	-0.01s (- 0.07%)	10.60s	10.82s
TFS - node (v8.9.0, x86)
Memory used	182,635k (± 0.03%)	184,525k (± 0.02%)	+1,890k (+ 1.03%)	184,462k	184,587k
Parse Time	1.30s (± 0.77%)	1.30s (± 1.33%)	-0.00s (- 0.00%)	1.28s	1.36s
Bind Time	0.71s (± 0.87%)	0.71s (± 1.15%)	+0.00s (+ 0.28%)	0.70s	0.73s
Check Time	4.58s (± 0.77%)	4.58s (± 0.60%)	-0.00s (- 0.02%)	4.53s	4.65s
Emit Time	2.96s (± 1.44%)	2.96s (± 1.68%)	-0.00s (- 0.17%)	2.86s	3.12s
Total Time	9.57s (± 0.68%)	9.56s (± 0.73%)	-0.01s (- 0.06%)	9.44s	9.75s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-166-generic
Architecture	x64
Available Memory	16 GB
Available Memory	4 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v10.16.3, x64)
• node (v12.1.0, x64)
• node (v8.9.0, x64)
• node (v8.9.0, x86)

Scenarios

• Angular - node (v10.16.3, x64)
• Angular - node (v12.1.0, x64)
• Angular - node (v8.9.0, x64)
• Angular - node (v8.9.0, x86)
• Monaco - node (v10.16.3, x64)
• Monaco - node (v12.1.0, x64)
• Monaco - node (v8.9.0, x64)
• Monaco - node (v8.9.0, x86)
• TFS - node (v10.16.3, x64)
• TFS - node (v12.1.0, x64)
• TFS - node (v8.9.0, x64)
• TFS - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	36667	10
Baseline	master	10

[weswigham]

It doesn't help the test case in #36562 :(