Skip to content

Add languages property to Navigator interface #15657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add languages property to Navigator interface #15657

wants to merge 1 commit into from

Conversation

wizawu
Copy link

@wizawu wizawu commented May 8, 2017

window.navigator.languages is already supported on some mainstream browsers and is ESSENTIAL for frontend to determine which interface language users prefer. For example, on Chrome, navigator.languages[0] indicates a more proper language option than navigator.language.
Please consider adding this property. Thank you!

@msftclas
Copy link

msftclas commented May 8, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mhegazy
Copy link
Contributor

mhegazy commented May 8, 2017

Thanks for your PR. these files are not manually edited, they are auto-generatd from a script in . You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TSJS-lib-generator.

Changes should be done in https://github.com/Microsoft/TSJS-lib-generator instead.

Please find more information at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

For future references, please file an issue first to track changes.

@mhegazy mhegazy closed this May 8, 2017
@HolgerJeromin
Copy link
Contributor

See #16246 which has a working pr

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants