fix #15666: mark file as optional in Diagnostic #15714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mhegazy merged 1 commit into microsoft:master from HerringtonDarkholme:lib

May 10, 2017

Contributor

HerringtonDarkholme commented May 10, 2017

Fixes #15666

IMHO, a better alternative is separate Diagnostic into GlobalDiagnostic which has no file associated and FileDiagnostic with source file.


          fix microsoft#15666: mark file as optional in Diagnostic

1bbc94f

msftclas added the cla-already-signed label

mhegazy merged commit 8321b81 into microsoft:master

microsoft locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet