session.ts: Revert some emptyArray back to undefined
#17781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
approved these changes
Aug 14, 2017
amcasey
reviewed
Aug 14, 2017
src/server/session.ts
Outdated
| @@ -585,7 +585,7 @@ namespace ts.server { | |||
| ): ReadonlyArray<protocol.DiagnosticWithLinePosition> | ReadonlyArray<protocol.Diagnostic> { | |||
| const { project, file } = this.getFileAndProject(args); | |||
| if (isSemantic && isDeclarationFileInJSOnlyNonConfiguredProject(project, file)) { | |||
| return emptyArray; | |||
| return undefined; | |||
There was a problem hiding this comment.
undefined [](start = 23, length = 9)
This appears to have been [] before your original change.
amcasey
reviewed
Aug 14, 2017
| @@ -601,7 +601,7 @@ namespace ts.server { | |||
|
|
|||
| const definitions = project.getLanguageService().getDefinitionAtPosition(file, position); | |||
| if (!definitions) { | |||
| return emptyArray; | |||
| return undefined; | |||
There was a problem hiding this comment.
undefined [](start = 23, length = 9)
This was probably fine as emptyArray, but I have no problem with reverting it.
amcasey
reviewed
Aug 14, 2017
| @@ -669,7 +669,7 @@ namespace ts.server { | |||
| const occurrences = project.getLanguageService().getOccurrencesAtPosition(file, position); | |||
|
|
|||
| if (!occurrences) { | |||
| return emptyArray; | |||
| return undefined; | |||
There was a problem hiding this comment.
undefined [](start = 23, length = 9)
Was probably fine.
There was a problem hiding this comment.
So -- leave it, or change it like this PR does?
There was a problem hiding this comment.
In master, whichever is more consistent with the other requests. My impression is that it's undefined. In release-2.5, whichever it used to return (also undefined?).
ghost
changed the base branch from
master
to
AddIsGlobalCompletionRestrictions
ghost
changed the base branch from
AddIsGlobalCompletionRestrictions
to
release-2.5
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the changes in #17165 that changed return values from
undefinedtoemptyArray.Does not revert any type-only changes or changes from
[]toemptyArray.Ref: #17165 (comment)