Skip to content

Avoid climbing ancestors in getAnyImportSyntax #17832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Aug 29, 2017
Merged

Avoid climbing ancestors in getAnyImportSyntax #17832

1 commit merged into from
Aug 29, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 16, 2017 •
edited by ghost
Loading

Usually a node does not have an import declaration as its ancestor. A findAncestor call like this will hurt performance as it makes us climb to the root node most of the time. (See #17831)

@ghost ghost requested a review from sandersn August 29, 2017 14:49
@ghost ghost merged commit 78524c1 into master Aug 29, 2017
@ghost ghost deleted the anyImportSyntax branch August 29, 2017 16:42
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @msftclas