Skip to content

Nested excess property checking for discriminated unions #21285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sandersn
Copy link
Member

Fixes #21187

Previously, unions and intersections would never do nested excess property checks. When the unions have a discriminant, nested checks are fine because only constituents matching the discriminant will be checked.

Previously, unions and intersections would never do nested excess
property checks. When the unions have a discriminant, nested checks are
fine because only constituents matching the discriminant will be
checked.
@sandersn
Copy link
Member Author

Looks like the linter failed because I forgot to add parameter-name comments.

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should remember to check if this gives us any RWC changes.

@sandersn
Copy link
Member Author

Nope, no RWC changes. There's only one outstanding change at the moment, but that's from Andy's improvement to type parameter error spans.

@sandersn sandersn merged commit b80081d into master Jan 25, 2018
@sandersn sandersn deleted the nested-excess-property-checking-for-discriminated-unions branch January 26, 2018 00:00
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants