Include arrow functions as javascript initializers #23068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that they are treated as valid js containers, methods, etc.
ghost
approved these changes
Apr 2, 2018
sandersn
deleted the
isMethodLike-recognises-arrows-as-js-prototype-methods
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that they are treated as valid js containers, methods, etc. These kind of 'methods' are present in at least webpack and clear-require, even though they can't access
this.Fixes a variant of #22895
Fixes part of #22637
Note that recognising arrow functions as methods is good for understanding existing code, but bad in that it doesn't prevent JS authors from writing possibly buggy new code.
I think the right thing is to prefer understanding existing code, since we hope people will write new code in Typescript. They will, at least, have years of experience lowering their expectations of the correctness of any new Javascript that they write.