Remove unused properties from patternMatcher #23076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
patternMatcher_unused
branch
from
e82ab53 to
1a5af5a
Compare
mhegazy
approved these changes
Apr 2, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patternMatcheris only used innavigateTo. These two unused properties seem intended for comparing two matches to get a best match, but we don't actually do that -- we just use the matches for thekindandisCaseSensitiveproperties, and then we only care about the minimum kind over all matches and whether every match was case sensitive, and don't really care about individual matches. It's possible that we could ferry more information along and makecompareNavigateToItemsmore complex, but don't know if that would be worth the trouble.