Skip to content

Treat host as possibly undefined for base64encode/base64decode #24641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Treat host as possibly undefined for base64encode/base64decode #24641

merged 1 commit into from
Jun 4, 2018

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jun 4, 2018

Fixes: #24638

Does not assume that ts.sys (a.k.a. host) is always defined, because when running on non-node/ChakraCore runtimes (e.g. deno), .sys does not get defined currently.

Here's a checklist you might find useful.

  • There is an associated issue that is labeled
    'Bug' or 'help wanted' or is in the Community milestone
  • Code is up-to-date with the master branch
  • You've successfully run jake runtests gulp runtests locally
  • You've signed the CLA
  • There are new or updated unit tests validating the change1

Fixes: #24638
Refs: ry/deno#117

[1]: I couldn't find any unit tests that were appropriate to update or add for this area of code. Would be glad to if someone could point out a related unit test.

@mhegazy mhegazy merged commit 5f6660b into microsoft:master Jun 4, 2018
@microsoft microsoft locked and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants