.d.ts files don't have outputs #25368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Jul 2, 2018
| @@ -295,7 +295,8 @@ namespace ts { | |||
| } | |||
|
|
|||
| function getOutputFileNames(inputFileName: string, configFile: ParsedCommandLine): ReadonlyArray<string> { | |||
| if (configFile.options.outFile) { | |||
| // outFile is handled elsewhere; .d.ts files don't generate outputs | |||
There was a problem hiding this comment.
And neither do .json if the allow json files flag is on, I believe?
mhegazy
reviewed
Jul 2, 2018
src/compiler/tsbuild.ts
Outdated
| function getOutputFileNames(inputFileName: string, configFile: ParsedCommandLine): ReadonlyArray<string> { | ||
| if (configFile.options.outFile) { | ||
| // outFile is handled elsewhere; .d.ts files don't generate outputs | ||
| if (configFile.options.outFile || fileExtensionIsOneOf(inputFileName, extensionsWithNoOutput)) { |
mhegazy
approved these changes
Jul 2, 2018
sheetalkamat
reviewed
Jul 2, 2018
src/compiler/tsbuild.ts
Outdated
| function getOutputFileNames(inputFileName: string, configFile: ParsedCommandLine): ReadonlyArray<string> { | ||
| if (configFile.options.outFile) { | ||
| // outFile is handled elsewhere; .d.ts files don't generate outputs |
There was a problem hiding this comment.
Json files are emitted just like js files. But they do not have sourcemaps.
There was a problem hiding this comment.
Really? So if I require/import my package.json it'll bet included in the emit? o.O
There was a problem hiding this comment.
Count me as surprised as well, but verified and this is the case
|
Interesting note: I had missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25355