Support for understanding some JSDoc annotations within JavaScript files. #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly setting parents.
Conflicts: src/compiler/binder.ts src/compiler/checker.ts
Conflicts: src/compiler/binder.ts src/compiler/checker.ts src/services/services.ts
Conflicts: src/compiler/checker.ts
Conflicts: src/compiler/checker.ts
|
@DanielRosenwasser @RyanCavanaugh @billti @zhengbli plz review. |
| // @type annotation might have been on the variable statement, try that instead. | ||
| let typeTag = getJSDocTypeTag(declaration.parent.parent); | ||
| if (typeTag) { | ||
| return typeTag.typeExpression.type; |
There was a problem hiding this comment.
will an invalid type tag, e.g. /** @type */ break the language service as the typeTag.typeExpression is undefined?
There was a problem hiding this comment.
Nope. We'll return an missing node there which will result in the undefinedType being. If we see the undefined type, we'll fall back to normal TS inference.
Closed
| @@ -538,7 +556,7 @@ namespace ts { | |||
| } | |||
| } | |||
|
|
|||
| function bindFunctionOrConstructorType(node: SignatureDeclaration) { | |||
| function bindFunctionOrConstructorTypeORJSDocFunctionType(node: SignatureDeclaration): void { | |||
|
closing this in favor of https://github.com/Microsoft/TypeScript/tree/JSDocAndJSModules |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be used in .js files to help inform the type system of the types of JS vars and functions.