Avoid circularly resolving names when looking up type members using resolveName #26924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
approved these changes
Sep 12, 2018
src/compiler/checker.ts
Outdated
| @@ -1312,7 +1312,7 @@ namespace ts { | |||
| case SyntaxKind.ClassDeclaration: | |||
| case SyntaxKind.ClassExpression: | |||
| case SyntaxKind.InterfaceDeclaration: | |||
| if (result = lookup(getMembersOfSymbol(getSymbolOfNode(location as ClassLikeDeclaration | InterfaceDeclaration)), name, meaning & SymbolFlags.Type)) { | |||
| if (result = lookup(getSymbolOfNode(location as ClassLikeDeclaration | InterfaceDeclaration).members || emptySymbols, name, meaning & SymbolFlags.Type)) { | |||
There was a problem hiding this comment.
We should document why we shouldn't resolve the members of the symbol here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMembersOfTypecauses computed late bound names to be evaluated and bound, which shouldn't happen during name resolution, as it is used.... during computed name and base type resolution (which must finish before late bound names are actually bindable).Fixes #23828