Skip to content

Consistently pass indent to 'parseTagComments' #27055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Sep 13, 2018
Merged

Consistently pass indent to 'parseTagComments' #27055

2 commits merged into from
Sep 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2018

Fixes #21123

@ghost ghost requested a review from sandersn September 12, 2018 19:07
sandersn
sandersn reviewed Sep 12, 2018
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a couple of tests still fail. Do they just need to be updated?

@ghost ghost merged commit 2b888c3 into master Sep 13, 2018
@ghost ghost deleted the indent branch September 13, 2018 00:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sandersn