CI Builds with GitHub Actions #34614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, we've got a few places using actions around our infra: And an almost ready for publishing blog post on it all 👍 |
|
Let's see what happens! |
weswigham
reviewed
Oct 23, 2019
| - name: Remove existing TypeScript | ||
| run: | | ||
| npm uninstall typescript --no-save | ||
| npm uninstall tslint --no-save |
There was a problem hiding this comment.
I'm pretty sure we can remove this from our scripts, since we don't use tslint anymore, XD
|
BTW @ethomson what's the open source project concurrent job/resource limit look like for actions? (Far as I can tell it's just "free", and the pricing model doesn't seem to have concurrency limits) Part of the reason we use pipelines for a bunch is because we have a lot of extra free extra parallel jobs allotted to us, which helps us do intensive on-demand testing around release periods without getting backlogged. |
mheiber
pushed a commit
to mheiber/TypeScript
that referenced
this pull request
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see if there was any interest in adding GitHub Actions to the party for validating pull request builds and merges into master.
This should be almost the same configuration as what you have for Azure Pipelines and Travis, except with a lack of caching. (Artifact caching is coming 🔜 to GitHub Actions, but I was curious how well it performed even without that.)
/cc @RyanCavanaugh