Include a stack in InitializationFailedResponse #38223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjbvz Looks like VS Code consumes the event, but doesn't produce telemetry? |
|
Yes, we've only used it in the past to show a warning to the user: https://github.com/microsoft/vscode/blob/951f891b235d4470403929523d64730d13411013/extensions/typescript-language-features/src/utils/typingsStatus.ts#L99 Would having telemetry for this also be helpful? |
|
@mjbvz It's nice to know how widespread errors are, but, anecdotally, this particular one is very low volume in VS. If you decide to add telemetry, you'll want to scrub it, as in microsoft/vscode#96108. |
andrewbranch
approved these changes
Apr 28, 2020
sheetalkamat
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just got lucky in being able to identify #38217 without a stack.