Skip to content

Feature/better object keys #40059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Feature/better object keys #40059

wants to merge 3 commits into from

Conversation

asosnovsky
Copy link

I got tired of always adding these two simple rules to my projects. I really think this should have been in the spec in the first place. Hopefully this tiny change will make sense :)

  • Code is up-to-date with the master branch
  • You've successfully run gulp runtests locally

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 14, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ asosnovsky sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@DanielRosenwasser
Copy link
Member

This is a duplicate and has been rejected multiple times: #12253 (comment), #30314, #13254. #30228, #28899, #28284, #26901, #30749, #31087, #32321, #34498, #35145, #37495, #38328, #38883. (thanks @MartinJohns for
#37495 (comment)!)

@MartinJohns
Copy link
Contributor

I actually stopped referencing all duplicate issues because @RyanCavanaugh made me worry. :-D

@DanielRosenwasser
Copy link
Member

I do something similar actually #27390 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants