Skip to content

chore: add dateStyle to DateTimeFormatOptions #40906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

hoop71
Copy link

@hoop71 hoop71 commented Oct 2, 2020

Fixes #40806

This PR adds support for dateStyle on DateTimeFormat

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 2, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

CLA assistant check
All CLA requirements met.

@orta
Copy link
Contributor

orta commented Oct 6, 2020

This proposal just made it to stage 4, https://github.com/tc39/proposal-intl-datetime-style#status -- which means it's likely to make it into ES2021 spec - adding it to es5 is probably a bad call (because that spec is ~10 years old), I think this should probably live as an interface extension in es2020.intl.d.ts

So I think it's good for us to take it, but I feel like it should probably live in a place which shows just how modern it is 👍🏻

@orta orta self-assigned this Oct 6, 2020
@hoop71
Copy link
Author

hoop71 commented Oct 7, 2020

This proposal just made it to stage 4, https://github.com/tc39/proposal-intl-datetime-style#status -- which means it's likely to make it into ES2021 spec - adding it to es5 is probably a bad call (because that spec is ~10 years old), I think this should probably live as an interface extension in es2020.intl.d.ts

So I think it's good for us to take it, but I feel like it should probably live in a place which shows just how modern it is 👍🏻

Great! Thanks for all that great information.

@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Oct 12, 2020
@orta
Copy link
Contributor

orta commented Dec 22, 2020

Thanks for the PR @hoop71 - I know it's been a while, I've jsut merged #41880 which builds on your PR and is a bit more accurate to the full types. This should be available in the next release!

@orta orta closed this Dec 22, 2020
@hoop71
Copy link
Author

hoop71 commented Dec 29, 2020

Thanks for the PR @hoop71 - I know it's been a while, I've jsut merged #41880 which builds on your PR and is a bit more accurate to the full types. This should be available in the next release!

Sweet! Thanks for the solve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug lib update PR modifies files in the `lib` folder
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Type '{ dateStyle: string; }' has no properties in common with type 'DateTimeFormatOptions'.ts(2559)
3 participants