-
Notifications
You must be signed in to change notification settings - Fork 12.8k
chore: add dateStyle to DateTimeFormatOptions #40906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This proposal just made it to stage 4, https://github.com/tc39/proposal-intl-datetime-style#status -- which means it's likely to make it into ES2021 spec - adding it to es5 is probably a bad call (because that spec is ~10 years old), I think this should probably live as an interface extension in So I think it's good for us to take it, but I feel like it should probably live in a place which shows just how modern it is 👍🏻 |
Great! Thanks for all that great information. |
It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'. |
Fixes #40806
This PR adds support for
dateStyle
on DateTimeFormat