Skip to content

Format template internal spaces #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2015

Conversation

saschanaz
Copy link
Contributor

Fixes #5030

Current:

throw Error(`${          JSON.stringify("") } cannot be found in ${                  JSON.stringify("") } while ${   3   }`);

Fix:

throw Error(`${JSON.stringify("")} cannot be found in ${JSON.stringify("")} while ${3}`);

@vladima
Copy link
Contributor

vladima commented Oct 5, 2015

👍

@DanielRosenwasser
Copy link
Member

What if a user just wants one space around their expressions?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 5, 2015

What if a user just wants one space around their expressions?

I think this is fair. this also applies to imports using import { x } from 'm' and for these, i would say we need a new option that allows for adding them or removing them.

mhegazy added a commit that referenced this pull request Oct 5, 2015
@mhegazy mhegazy merged commit 53cff21 into microsoft:master Oct 5, 2015
@Arnavion
Copy link
Contributor

I really would like that option for template strings. With 1.7 in new VS I have to fight it every time I auto-format :( Should I open a new issue?

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants