Skip to content

Cherry-pick #51704 to release 4.9 #51712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

RyanCavanaugh
Copy link
Member

Ports #51704 manually to the 4.9 branch. Testcase not included since this is a terminal branch

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 1, 2022
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but would appreciate adding the test case anyway since 4.9.5 and other patch changes may come in.

@bradennapier
Copy link

bradennapier commented Dec 3, 2022

@DanielRosenwasser Do you guys currently think 4.9.4 is published? The code is set as merged and released from what I could tell but we can not install it and it has a critical regression fix for quite a few dependents. Just asking since this is expecting 4.9.5

#51542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants