Remove redundant code from getResolvedSignatureWorker
#52721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Andarist
force-pushed
the
cleanup/getResolvedSignatureWorker
branch
from
91adbd2 to
226985f
Compare
|
@typescript-bot user test |
|
Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 226985f. You can monitor the build here. Update: The results are in! |
andrewbranch
requested changes
Feb 10, 2023
|
In such a case, there is no point in this PR. More meaningful changes in this code are happening here anyway |
|
@andrewbranch Here are the results of running the top-repos suite comparing Everything looks good! |
|
@andrewbranch I got curious about this case - is there a way to write a unit~ test that would cover this scenario? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while investigating what extra tests I should add as part of #52679 i noticed that some pieces here might not be needed (at least according to the existing test suite)