Always create a temporary for iterated expressions in a for-of loop #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbuckton can you take a look. |
| @@ -3614,10 +3614,12 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, Promi | |||
| // | |||
| // for (let v of arr) { } | |||
| // | |||
| // we don't want to emit a temporary variable for the RHS, just use it directly. | |||
| let rhsIsIdentifier = node.expression.kind === SyntaxKind.Identifier; | |||
| // we can't reuse 'arr' because it might be modified within the body of the loop. | |||
There was a problem hiding this comment.
One possibility might be to check if the rhs is declared as const, and then we can emit it inline.
|
Other than the |
| let rhsReference = createSynthesizedNode(SyntaxKind.Identifier) as Identifier; | ||
| rhsReference.text = node.expression.kind === SyntaxKind.Identifier ? | ||
| makeUniqueName((<Identifier>node.expression).text) : | ||
| makeTempVariableName(TempFlags.Auto); |
There was a problem hiding this comment.
Could you add tests for this case?
There was a problem hiding this comment.
We already have tests for that case
|
otherwise lgtm |
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 31, 2015
Always create a temporary for iterated expressions in a for-of loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5475. The only special handling we use now is that we create a name based on the original identifier if we had an identifier.