Skip to content

Remove RWC runner and related infrastructure #55187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

jakebailey
Copy link
Member

We've previously talked about this one; this infra is a pain to maintain, isn't visible to the public (we have to copy/paste and self-censor the internal repos we show), and we can't import tests into it anymore post-modules (as the mechanism used to "instrument" tsc was removed). I've already removed all of the other "special" runners (user, docker, DT, test262), so after this PR we'll only have the tests that exist fully in this repo, and those in https://github.com/microsoft/TypeScript-error-deltas.

A downside is that there may be things tested in RWC that aren't tested in our in-repo test suite or in user/topXYZ tests.

Notably, RWC baselines emit while our other external test cases do not, but from being the one to update those baselines when main fails, it doesn't really seem like we actually get much out of it as the emit changes are always very clearly reflected in tests.

Additionally, RWC is one of the only places with existing errors, which do provide a mechanism to observe how error messages are changing. It's likely that user/topXYZ tests don't contain any errors except the new ones we add in a release. But it's a double edged sword; the reason the RWC projects have errors is because they're all 3+ years old and are never updated. Most of them contain 5.0 option deprecation errors!

I'm not sure we're "ready" for this, but I do want to discuss it. I'm finding it increasingly annoying to fix RWC up; we've broken the test runner without noticing multiple times this year, its ability to push PRs to the internal repo is currently broken, and often its ability to post github replies also breaks. It's just annoying.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 28, 2023
@jakebailey jakebailey merged commit 7eece9f into microsoft:main Aug 7, 2023
@jakebailey jakebailey deleted the remove-rwc branch August 7, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants