Fixed symbol lookup for binding expando properties in blocks #56552

Andarist · 2023-11-26T22:55:12Z

jakebailey · 2023-11-27T18:48:39Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-11-27T18:48:42Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at ea9db5d. You can monitor the build here.

typescript-bot · 2023-11-27T18:48:42Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at ea9db5d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-27T18:48:42Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at ea9db5d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-27T18:48:42Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at ea9db5d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-27T18:48:42Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at ea9db5d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-27T18:50:25Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158814/artifacts?artifactName=tgz&fileId=9749F92E321D6BE78278F6D8D85D3E042CCC71D6CE55A59166636027602775F502&fileName=/typescript-5.4.0-insiders.20231127.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56552-6".;

typescript-bot · 2023-11-27T19:07:20Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56552/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-11-27T19:12:19Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,177k (± 0.00%)}	_{295,177k (± 0.01%)}	_~	_295,135k	_295,234k	_{p=0.810 n=6}
_{Parse Time}	_{2.65s (± 0.21%)}	_{2.65s (± 0.34%)}	_~	_2.64s	_2.66s	_{p=0.341 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=0.405 n=6}
_{Check Time}	_{8.04s (± 0.24%)}	_{8.04s (± 0.20%)}	_~	_8.02s	_8.06s	_{p=0.934 n=6}
_{Emit Time}	_{7.08s (± 0.36%)}	_{7.08s (± 0.19%)}	_~	_7.06s	_7.10s	_{p=0.870 n=6}
_{Total Time}	_{18.59s (± 0.16%)}	_{18.59s (± 0.10%)}	_~	_18.56s	_18.62s	_{p=0.868 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,660k (± 1.68%)}	_{195,562k (± 1.22%)}	_~	_190,678k	_196,701k	_{p=0.689 n=6}
_{Parse Time}	_{1.35s (± 0.81%)}	_{1.36s (± 1.14%)}	_~	_1.35s	_1.38s	_{p=0.179 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.18s (± 0.36%)}	_{9.19s (± 0.60%)}	_~	_9.10s	_9.25s	_{p=0.747 n=6}
_{Emit Time}	_{2.62s (± 0.54%)}	_{2.61s (± 1.10%)}	_~	_2.56s	_2.64s	_{p=1.000 n=6}
_{Total Time}	_{13.88s (± 0.21%)}	_{13.88s (± 0.49%)}	_~	_13.77s	_13.95s	_{p=0.686 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,357k (± 0.01%)}	_{347,363k (± 0.00%)}	_~	_347,348k	_347,380k	_{p=0.378 n=6}
_{Parse Time}	_{2.44s (± 0.62%)}	_{2.47s (± 0.49%)}	_{+0.02s (+ 0.95%)}	_2.45s	_2.48s	_{p=0.029 n=6}
_{Bind Time}	_{0.92s (± 0.44%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.112 n=6}
_{Check Time}	_{6.92s (± 0.35%)}	_{6.91s (± 0.56%)}	_~	_6.85s	_6.96s	_{p=0.466 n=6}
_{Emit Time}	_{4.05s (± 0.27%)}	_{4.04s (± 0.41%)}	_~	_4.02s	_4.07s	_{p=0.228 n=6}
_{Total Time}	_{14.34s (± 0.16%)}	_{14.35s (± 0.29%)}	_~	_14.29s	_14.40s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,641k (± 0.00%)}	_{302,644k (± 0.01%)}	_~	_302,624k	_302,717k	_{p=0.230 n=6}
_{Parse Time}	_{2.00s (± 0.73%)}	_{2.00s (± 0.66%)}	_~	_1.99s	_2.02s	_{p=0.737 n=6}
_{Bind Time}	_{1.00s (± 1.09%)}	_{1.01s (± 0.81%)}	_~	_1.00s	_1.02s	_{p=0.197 n=6}
_{Check Time}	_{6.27s (± 0.39%)}	_{6.28s (± 0.42%)}	_~	_6.26s	_6.33s	_{p=0.193 n=6}
_{Emit Time}	_{3.58s (± 0.29%)}	_{3.60s (± 0.46%)}	_{+0.02s (+ 0.56%)}	_3.57s	_3.62s	_{p=0.042 n=6}
_{Total Time}	_{12.84s (± 0.30%)}	_{12.88s (± 0.22%)}	_~	_12.84s	_12.93s	_{p=0.225 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,604k (± 0.02%)}	_{470,593k (± 0.00%)}	_~	_470,573k	_470,631k	_{p=0.936 n=6}
_{Parse Time}	_{2.57s (± 0.45%)}	_{2.57s (± 0.68%)}	_~	_2.55s	_2.60s	_{p=0.511 n=6}
_{Bind Time}	_{0.98s (± 0.56%)}	_{1.00s (± 0.82%)}	_{+0.01s (+ 1.18%)}	_0.99s	_1.01s	_{p=0.025 n=6}
_{Check Time}	_{16.75s (± 0.28%)}	_{16.79s (± 0.24%)}	_~	_16.74s	_16.83s	_{p=0.120 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.30s (± 0.30%)}	_{20.36s (± 0.30%)}	_~	_20.27s	_20.44s	_{p=0.077 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{511,926k (± 0.02%)}	_{511,986k (± 0.01%)}	_~	_511,932k	_512,056k	_{p=0.230 n=6}
_{Parse Time}	_{3.27s (± 0.16%)}	_{3.27s (± 0.39%)}	_~	_3.26s	_3.29s	_{p=0.931 n=6}
_{Bind Time}	_{1.54s (± 0.41%)}	_{1.55s (± 0.53%)}	_~	_1.54s	_1.56s	_{p=0.177 n=6}
_{Check Time}	_{2.80s (± 0.74%)}	_{2.81s (± 1.09%)}	_~	_2.77s	_2.86s	_{p=0.747 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.68s (± 0.32%)}	_{7.69s (± 0.40%)}	_~	_7.66s	_7.75s	_{p=0.572 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,357ms (± 0.24%)}	_{2,357ms (± 0.76%)}	_~	_2,332ms	_2,380ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{5,397ms (± 1.40%)}	_{5,376ms (± 1.40%)}	_~	_5,323ms	_5,497ms	_{p=0.873 n=6}
_{Req 3 - references}	_{327ms (± 1.21%)}	_{326ms (± 0.63%)}	_~	_324ms	_329ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{278ms (± 0.95%)}	_{278ms (± 1.06%)}	_~	_273ms	_280ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 6.00%)}	_{84ms (± 6.09%)}	_~	_79ms	_90ms	_{p=0.498 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,472ms (± 0.99%)}	_{2,488ms (± 1.50%)}	_~	_2,450ms	_2,553ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,090ms (± 1.96%)}	_{4,070ms (± 1.79%)}	_~	_4,020ms	_4,170ms	_{p=0.809 n=6}
_{Req 3 - references}	_{340ms (± 1.62%)}	_{341ms (± 1.57%)}	_~	_334ms	_345ms	_{p=0.744 n=6}
_{Req 4 - navto}	_{283ms (± 0.37%)}	_{284ms (± 0.18%)}	_~	_283ms	_284ms	_{p=0.051 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 7.38%)}	_{85ms (± 6.93%)}	_~	_77ms	_90ms	_{p=0.505 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,592ms (± 0.46%)}	_{2,585ms (± 0.66%)}	_~	_2,563ms	_2,603ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,656ms (± 1.48%)}	_{1,659ms (± 1.92%)}	_~	_1,623ms	_1,697ms	_{p=1.000 n=6}
_{Req 3 - references}	_{105ms (± 4.67%)}	_{112ms (± 8.68%)}	_~	_101ms	_124ms	_{p=0.334 n=6}
_{Req 4 - navto}	_{366ms (± 0.33%)}	_{367ms (± 0.50%)}	_~	_364ms	_369ms	_{p=0.256 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{308ms (± 1.03%)}	_{305ms (± 2.07%)}	_~	_296ms	_314ms	_{p=0.376 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.78ms (± 0.21%)}	_{152.74ms (± 0.21%)}	_~	_151.59ms	_156.40ms	_{p=0.106 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.13ms (± 0.15%)}	_{227.92ms (± 0.14%)}	_{-0.21ms (- 0.09%)}	_226.71ms	_230.61ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.60ms (± 0.17%)}	_{229.72ms (± 0.20%)}	_{+0.12ms (+ 0.05%)}	_227.94ms	_236.24ms	_{p=0.048 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.16ms (± 0.17%)}	_{229.17ms (± 0.18%)}	_~	_227.57ms	_232.64ms	_{p=0.844 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-27T19:40:22Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-11-27T20:40:47Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56552/merge:

Everything looks good!

Fixed symbol lookup for binding expando properties in blocks

ea9db5d

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 26, 2023

weswigham approved these changes Nov 29, 2023

View reviewed changes

weswigham merged commit e551325 into microsoft:main Nov 29, 2023

Andarist deleted the fix/expando-block-shadowing branch September 2, 2024 16:55

Andarist mentioned this pull request Sep 2, 2024

Fixed symbol lookup for binding expando properties in nested blocks #59828

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed symbol lookup for binding expando properties in blocks #56552

Fixed symbol lookup for binding expando properties in blocks #56552

Andarist commented Nov 26, 2023

jakebailey commented Nov 27, 2023

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 27, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 27, 2023

typescript-bot commented Nov 27, 2023

Fixed symbol lookup for binding expando properties in blocks #56552

Fixed symbol lookup for binding expando properties in blocks #56552

Conversation

Andarist commented Nov 26, 2023

jakebailey commented Nov 27, 2023

typescript-bot commented Nov 27, 2023 • edited Loading

typescript-bot commented Nov 27, 2023 • edited Loading

typescript-bot commented Nov 27, 2023 • edited Loading

typescript-bot commented Nov 27, 2023 • edited Loading

typescript-bot commented Nov 27, 2023 • edited Loading

typescript-bot commented Nov 27, 2023 • edited Loading

typescript-bot commented Nov 27, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 27, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 27, 2023

typescript-bot commented Nov 27, 2023

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading

typescript-bot commented Nov 27, 2023 •

edited

Loading