Infer between generic mapped types before inferring from apparent type #56640

gabritto · 2023-12-01T22:00:35Z

gabritto · 2023-12-01T22:08:43Z

@typescript-bot run DT
@typescript-bot user test this
@typescript-bot test top100
@typescript-bot perf test this

gabritto · 2023-12-01T22:13:41Z

@typescript-bot run DT
@typescript-bot user test this
@typescript-bot test top100
@typescript-bot perf test this

typescript-bot · 2023-12-01T22:13:44Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-01T22:13:44Z

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-01T22:13:44Z

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-01T22:13:44Z

Heya @gabritto, I've started to run the regular perf test suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-01T22:32:01Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/56640/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-12-01T22:33:32Z

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,379k (± 0.00%)}	_{295,416k (± 0.01%)}	_~	_295,372k	_295,448k	_{p=0.065 n=6}
_{Parse Time}	_{2.64s (± 0.44%)}	_{2.65s (± 0.32%)}	_~	_2.63s	_2.65s	_{p=0.652 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=0.405 n=6}
_{Check Time}	_{8.12s (± 0.16%)}	_{8.13s (± 0.32%)}	_~	_8.09s	_8.15s	_{p=0.625 n=6}
_{Emit Time}	_{7.08s (± 0.36%)}	_{7.07s (± 0.21%)}	_~	_7.04s	_7.08s	_{p=0.324 n=6}
_{Total Time}	_{18.67s (± 0.17%)}	_{18.66s (± 0.09%)}	_~	_18.64s	_18.68s	_{p=0.737 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{195,311k (± 1.54%)}	_{193,761k (± 1.46%)}	_~	_191,392k	_197,207k	_{p=0.128 n=6}
_{Parse Time}	_{1.36s (± 1.36%)}	_{1.35s (± 0.81%)}	_~	_1.34s	_1.37s	_{p=0.206 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.27s (± 0.40%)}	_{9.29s (± 0.31%)}	_~	_9.25s	_9.33s	_{p=0.469 n=6}
_{Emit Time}	_{2.61s (± 0.67%)}	_{2.62s (± 0.52%)}	_~	_2.60s	_2.64s	_{p=0.287 n=6}
_{Total Time}	_{13.97s (± 0.34%)}	_{13.98s (± 0.28%)}	_~	_13.94s	_14.05s	_{p=0.568 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,378k (± 0.01%)}	_{347,390k (± 0.01%)}	_~	_347,358k	_347,410k	_{p=0.630 n=6}
_{Parse Time}	_{2.45s (± 0.31%)}	_{2.46s (± 0.31%)}	_~	_2.45s	_2.47s	_{p=0.062 n=6}
_{Bind Time}	_{0.92s (± 0.59%)}	_{0.93s (± 0.68%)}	_~	_0.92s	_0.94s	_{p=0.201 n=6}
_{Check Time}	_{6.91s (± 0.18%)}	_{6.92s (± 0.33%)}	_~	_6.88s	_6.94s	_{p=0.290 n=6}
_{Emit Time}	_{4.08s (± 0.83%)}	_{4.05s (± 0.48%)}	_~	_4.02s	_4.07s	_{p=0.253 n=6}
_{Total Time}	_{14.37s (± 0.25%)}	_{14.35s (± 0.14%)}	_~	_14.32s	_14.38s	_{p=0.746 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,662k (± 0.01%)}	_{302,679k (± 0.01%)}	_~	_302,653k	_302,751k	_{p=0.298 n=6}
_{Parse Time}	_{1.99s (± 1.58%)}	_{2.00s (± 1.07%)}	_~	_1.98s	_2.03s	_{p=0.626 n=6}
_{Bind Time}	_{1.01s (± 1.49%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.02s	_{p=0.654 n=6}
_{Check Time}	_{6.30s (± 0.28%)}	_{6.29s (± 0.30%)}	_~	_6.26s	_6.31s	_{p=0.511 n=6}
_{Emit Time}	_{3.58s (± 0.49%)}	_{3.58s (± 0.21%)}	_~	_3.57s	_3.59s	_{p=0.620 n=6}
_{Total Time}	_{12.88s (± 0.39%)}	_{12.87s (± 0.25%)}	_~	_12.82s	_12.91s	_{p=0.686 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,768k (± 0.00%)}	_{506,750k (± 0.01%)}	_~	_506,724k	_506,819k	_{p=0.173 n=6}
_{Parse Time}	_{2.58s (± 0.57%)}	_{2.59s (± 0.76%)}	_~	_2.57s	_2.61s	_{p=0.206 n=6}
_{Bind Time}	_{0.99s (± 1.11%)}	_{1.00s (± 0.82%)}	_~	_0.99s	_1.01s	_{p=0.197 n=6}
_{Check Time}	_{16.84s (± 0.38%)}	_{16.91s (± 0.30%)}	_~	_16.83s	_16.96s	_{p=0.126 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.41s (± 0.36%)}	_{20.49s (± 0.25%)}	_{+0.08s (+ 0.39%)}	_20.42s	_20.56s	_{p=0.042 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,725k (± 0.01%)}	_{512,724k (± 0.01%)}	_~	_512,682k	_512,794k	_{p=0.575 n=6}
_{Parse Time}	_{3.27s (± 0.36%)}	_{3.27s (± 0.12%)}	_~	_3.27s	_3.28s	_{p=0.858 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=1.000 n=6}
_{Check Time}	_{2.81s (± 0.27%)}	_{2.82s (± 0.61%)}	_~	_2.79s	_2.84s	_{p=0.087 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.69s (± 0.11%)}	_{7.71s (± 0.15%)}	_{+0.02s (+ 0.19%)}	_7.69s	_7.72s	_{p=0.037 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,347ms (± 0.73%)}	_{2,343ms (± 0.69%)}	_~	_2,321ms	_2,362ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{5,434ms (± 1.74%)}	_{5,437ms (± 1.18%)}	_~	_5,338ms	_5,492ms	_{p=0.689 n=6}
_{Req 3 - references}	_{323ms (± 0.71%)}	_{327ms (± 1.74%)}	_~	_320ms	_334ms	_{p=0.295 n=6}
_{Req 4 - navto}	_{277ms (± 1.34%)}	_{275ms (± 1.18%)}	_~	_273ms	_280ms	_{p=0.504 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 7.45%)}	_{87ms (± 5.22%)}	_~	_81ms	_90ms	_{p=0.863 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,488ms (± 0.83%)}	_{2,488ms (± 1.52%)}	_~	_2,428ms	_2,530ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{4,096ms (± 1.61%)}	_{4,123ms (± 1.75%)}	_~	_4,057ms	_4,216ms	_{p=0.298 n=6}
_{Req 3 - references}	_{344ms (± 1.43%)}	_{342ms (± 1.48%)}	_~	_335ms	_347ms	_{p=0.520 n=6}
_{Req 4 - navto}	_{285ms (± 0.34%)}	_{286ms (± 1.40%)}	_~	_283ms	_294ms	_{p=0.858 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 5.73%)}	_{85ms (± 7.90%)}	_~	_76ms	_90ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,591ms (± 0.59%)}	_{2,606ms (± 0.49%)}	_~	_2,587ms	_2,619ms	_{p=0.077 n=6}
_{Req 2 - geterr}	_{1,689ms (± 2.19%)}	_{1,679ms (± 1.81%)}	_~	_1,651ms	_1,719ms	_{p=0.575 n=6}
_{Req 3 - references}	_{117ms (± 9.37%)}	_{104ms (± 5.02%)}	_{🟩-12ms (-10.44%)}	_102ms	_115ms	_{p=0.046 n=6}
_{Req 4 - navto}	_{364ms (± 0.47%)}	_{364ms (± 0.80%)}	_~	_358ms	_366ms	_{p=0.565 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{312ms (± 2.11%)}	_{311ms (± 2.66%)}	_~	_304ms	_323ms	_{p=0.872 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.57ms (± 0.19%)}	_{152.51ms (± 0.18%)}	_~	_151.45ms	_154.74ms	_{p=0.062 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.95ms (± 0.15%)}	_{227.76ms (± 0.22%)}	_{-0.20ms (- 0.09%)}	_226.26ms	_244.38ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.31ms (± 0.17%)}	_{229.31ms (± 0.19%)}	_~	_227.60ms	_234.57ms	_{p=0.549 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.20ms (± 0.17%)}	_{229.15ms (± 0.18%)}	_~	_227.71ms	_232.28ms	_{p=0.120 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-12-01T23:06:25Z

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-12-01T23:06:46Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/56640/merge:

Everything looks good!

gabritto · 2023-12-01T23:38:04Z

@typescript-bot test top300

typescript-bot · 2023-12-01T23:38:07Z

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 88f7f12. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-02T02:39:34Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/56640/merge:

Everything looks good!

gabritto · 2023-12-07T23:13:38Z

@typescript-bot pack this

typescript-bot · 2023-12-07T23:13:40Z

Heya @gabritto, I've started to run the tarball bundle task on this PR at 88f7f12. You can monitor the build here.

typescript-bot · 2023-12-07T23:15:47Z

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159017/artifacts?artifactName=tgz&fileId=DCA5A96FD292469CC766CCC55F42CE569146C7627ECF2E4447A5C661ADEE920902&fileName=/typescript-5.4.0-insiders.20231207.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-56640-15".;

gabritto · 2023-12-14T00:37:59Z

@typescript-bot run DT
@typescript-bot user test this
@typescript-bot test top300
@typescript-bot perf test this

typescript-bot · 2023-12-14T00:38:02Z

Heya @gabritto, I've started to run the regular perf test suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-14T00:38:02Z

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-14T00:38:02Z

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-14T00:38:02Z

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at d867225. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-12-14T00:56:34Z

@gabritto Here are the results of running the user test suite comparing main and refs/pull/56640/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-12-14T00:58:05Z

@gabritto
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,417k (± 0.01%)}	_{295,442k (± 0.01%)}	_~	_295,382k	_295,486k	_{p=0.229 n=6}
_{Parse Time}	_{2.65s (± 0.21%)}	_{2.65s (± 0.21%)}	_~	_2.64s	_2.65s	_{p=1.000 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.50%)}	_~	_0.82s	_0.83s	_{p=0.405 n=6}
_{Check Time}	_{8.15s (± 0.39%)}	_{8.14s (± 0.27%)}	_~	_8.12s	_8.18s	_{p=0.871 n=6}
_{Emit Time}	_{7.10s (± 0.40%)}	_{7.09s (± 0.21%)}	_~	_7.07s	_7.11s	_{p=0.808 n=6}
_{Total Time}	_{18.72s (± 0.23%)}	_{18.70s (± 0.12%)}	_~	_18.66s	_18.73s	_{p=0.871 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{194,396k (± 1.64%)}	_{191,951k (± 0.57%)}	_~	_191,454k	_194,200k	_{p=0.521 n=6}
_{Parse Time}	_{1.35s (± 1.27%)}	_{1.35s (± 1.01%)}	_~	_1.34s	_1.38s	_{p=0.932 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.24s (± 0.51%)}	_{9.24s (± 0.41%)}	_~	_9.18s	_9.29s	_{p=1.000 n=6}
_{Emit Time}	_{2.63s (± 0.70%)}	_{2.63s (± 0.71%)}	_~	_2.61s	_2.66s	_{p=0.935 n=6}
_{Total Time}	_{13.94s (± 0.32%)}	_{13.94s (± 0.37%)}	_~	_13.86s	_13.99s	_{p=0.746 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,397k (± 0.00%)}	_{347,378k (± 0.01%)}	_~	_347,349k	_347,405k	_{p=0.149 n=6}
_{Parse Time}	_{2.45s (± 0.49%)}	_{2.46s (± 0.33%)}	_~	_2.45s	_2.47s	_{p=0.157 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.92s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.87s (± 0.25%)}	_{6.88s (± 0.23%)}	_~	_6.86s	_6.90s	_{p=0.192 n=6}
_{Emit Time}	_{4.06s (± 0.20%)}	_{4.04s (± 0.26%)}	_~	_4.03s	_4.06s	_{p=0.078 n=6}
_{Total Time}	_{14.30s (± 0.12%)}	_{14.31s (± 0.15%)}	_~	_14.28s	_14.34s	_{p=0.331 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,660k (± 0.01%)}	_{302,662k (± 0.00%)}	_~	_302,654k	_302,670k	_{p=0.936 n=6}
_{Parse Time}	_{1.99s (± 0.99%)}	_{1.99s (± 0.88%)}	_~	_1.96s	_2.01s	_{p=0.867 n=6}
_{Bind Time}	_{1.01s (± 1.20%)}	_{1.00s (± 1.21%)}	_~	_0.99s	_1.02s	_{p=0.680 n=6}
_{Check Time}	_{6.28s (± 0.27%)}	_{6.28s (± 0.33%)}	_~	_6.25s	_6.29s	_{p=1.000 n=6}
_{Emit Time}	_{3.58s (± 0.14%)}	_{3.58s (± 0.39%)}	_~	_3.56s	_3.60s	_{p=0.667 n=6}
_{Total Time}	_{12.86s (± 0.18%)}	_{12.85s (± 0.16%)}	_~	_12.82s	_12.88s	_{p=0.463 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{506,788k (± 0.01%)}	_{506,806k (± 0.01%)}	_~	_506,768k	_506,852k	_{p=0.378 n=6}
_{Parse Time}	_{2.59s (± 0.29%)}	_{2.59s (± 0.58%)}	_~	_2.57s	_2.61s	_{p=0.492 n=6}
_{Bind Time}	_{0.99s (± 1.05%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.931 n=6}
_{Check Time}	_{16.88s (± 0.29%)}	_{16.95s (± 0.49%)}	_~	_16.82s	_17.07s	_{p=0.077 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.46s (± 0.26%)}	_{20.52s (± 0.42%)}	_~	_20.40s	_20.66s	_{p=0.127 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,906k (± 0.02%)}	_{512,848k (± 0.01%)}	_~	_512,795k	_512,950k	_{p=0.173 n=6}
_{Parse Time}	_{3.27s (± 0.23%)}	_{3.27s (± 0.17%)}	_~	_3.26s	_3.27s	_{p=0.137 n=6}
_{Bind Time}	_{1.54s (± 0.41%)}	_{1.53s (± 0.36%)}	_~	_1.53s	_1.54s	_{p=0.201 n=6}
_{Check Time}	_{2.83s (± 0.47%)}	_{2.82s (± 0.83%)}	_~	_2.79s	_2.86s	_{p=0.413 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 7.03%)}	_~	_0.07s	_0.08s	_{p=0.174 n=6}
_{Total Time}	_{7.71s (± 0.13%)}	_{7.70s (± 0.24%)}	_~	_7.67s	_7.72s	_{p=0.255 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,359ms (± 0.58%)}	_{2,349ms (± 1.19%)}	_~	_2,315ms	_2,376ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{5,373ms (± 0.50%)}	_{5,362ms (± 1.11%)}	_~	_5,308ms	_5,476ms	_{p=0.229 n=6}
_{Req 3 - references}	_{325ms (± 0.90%)}	_{326ms (± 0.57%)}	_~	_324ms	_328ms	_{p=0.677 n=6}
_{Req 4 - navto}	_{280ms (± 0.69%)}	_{279ms (± 0.85%)}	_~	_276ms	_281ms	_{p=0.550 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 6.67%)}	_{86ms (± 5.69%)}	_~	_82ms	_94ms	_{p=0.801 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,470ms (± 1.35%)}	_{2,474ms (± 0.85%)}	_~	_2,436ms	_2,498ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,142ms (± 1.90%)}	_{4,170ms (± 1.90%)}	_~	_4,063ms	_4,237ms	_{p=0.423 n=6}
_{Req 3 - references}	_{340ms (± 1.07%)}	_{338ms (± 0.70%)}	_~	_335ms	_341ms	_{p=0.295 n=6}
_{Req 4 - navto}	_{287ms (± 1.39%)}	_{286ms (± 1.19%)}	_~	_283ms	_292ms	_{p=0.514 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 6.29%)}	_{81ms (± 7.52%)}	_~	_76ms	_89ms	_{p=0.361 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,602ms (± 0.59%)}	_{2,600ms (± 0.22%)}	_~	_2,592ms	_2,609ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{1,719ms (± 1.81%)}	_{1,698ms (± 3.28%)}	_~	_1,637ms	_1,773ms	_{p=0.378 n=6}
_{Req 3 - references}	_{109ms (± 9.00%)}	_{112ms (± 9.55%)}	_~	_102ms	_124ms	_{p=0.870 n=6}
_{Req 4 - navto}	_{366ms (± 0.47%)}	_{364ms (± 0.14%)}	_~	_364ms	_365ms	_{p=0.051 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 1.97%)}	_{304ms (± 1.67%)}	_~	_298ms	_311ms	_{p=0.520 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.06ms (± 0.20%)}	_{153.05ms (± 0.21%)}	_~	_151.75ms	_158.28ms	_{p=0.216 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.22ms (± 0.14%)}	_{228.15ms (± 0.16%)}	_{-0.07ms (- 0.03%)}	_226.84ms	_232.38ms	_{p=0.004 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.77ms (± 0.20%)}	_{229.68ms (± 0.19%)}	_{-0.09ms (- 0.04%)}	_228.08ms	_237.00ms	_{p=0.022 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.36ms (± 0.16%)}	_{229.35ms (± 0.17%)}	_~	_227.86ms	_233.02ms	_{p=0.509 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-12-14T01:27:20Z

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-12-14T02:54:06Z

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/56640/merge:

Everything looks good!

gabritto added 3 commits November 30, 2023 14:29

add test

6b04aef

add regression test

47cb9bc

breaking change

88f7f12

typescript-bot assigned gabritto Dec 1, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 1, 2023

DanielRosenwasser mentioned this pull request Dec 9, 2023

Design Meeting Notes, 12/8/2023 #56717

Closed

gabritto added 2 commits December 12, 2023 17:12

cleanup

4dcc69a

add documentation to invokeOnce

d867225

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 14, 2023

gabritto marked this pull request as ready for review December 14, 2023 00:37

gabritto changed the title ~~Gabritto/issue56133~~ Infer between generic mapped types before inferring from apparent type Dec 14, 2023

weswigham approved these changes Jan 2, 2024

View reviewed changes

gabritto merged commit be20dbb into main Jan 2, 2024

gabritto deleted the gabritto/issue56133 branch January 2, 2024 23:35

Infer between generic mapped types before inferring from apparent type #56640

Infer between generic mapped types before inferring from apparent type #56640

Conversation

gabritto commented Dec 1, 2023 • edited Loading

gabritto commented Dec 1, 2023

gabritto commented Dec 1, 2023

typescript-bot commented Dec 1, 2023 • edited Loading

typescript-bot commented Dec 1, 2023 • edited Loading

typescript-bot commented Dec 1, 2023 • edited Loading

typescript-bot commented Dec 1, 2023 • edited Loading

typescript-bot commented Dec 1, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Dec 1, 2023

Compiler

tsserver

Startup

typescript-bot commented Dec 1, 2023

typescript-bot commented Dec 1, 2023

gabritto commented Dec 1, 2023

typescript-bot commented Dec 1, 2023 • edited Loading

typescript-bot commented Dec 2, 2023

gabritto commented Dec 7, 2023

typescript-bot commented Dec 7, 2023 • edited Loading

typescript-bot commented Dec 7, 2023 • edited Loading

gabritto commented Dec 14, 2023

typescript-bot commented Dec 14, 2023 • edited Loading

typescript-bot commented Dec 14, 2023 • edited Loading

typescript-bot commented Dec 14, 2023 • edited Loading

typescript-bot commented Dec 14, 2023 • edited Loading

typescript-bot commented Dec 14, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Dec 14, 2023

Compiler

tsserver

Startup

typescript-bot commented Dec 14, 2023

typescript-bot commented Dec 14, 2023

gabritto commented Dec 1, 2023 •

edited

Loading

typescript-bot commented Dec 1, 2023 •

edited

Loading

typescript-bot commented Dec 1, 2023 •

edited

Loading

typescript-bot commented Dec 1, 2023 •

edited

Loading

typescript-bot commented Dec 1, 2023 •

edited

Loading

typescript-bot commented Dec 1, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 7, 2023 •

edited

Loading

typescript-bot commented Dec 14, 2023 •

edited

Loading

typescript-bot commented Dec 14, 2023 •

edited

Loading

typescript-bot commented Dec 14, 2023 •

edited

Loading

typescript-bot commented Dec 14, 2023 •

edited

Loading