check return type of this type predicates #57341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test top200 @typescript-bot perf test this faster |
|
Heya @jakebailey, I've started to run the tarball bundle task on this PR at 89a7208. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 89a7208. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 89a7208. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 89a7208. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the faster perf test suite on this PR at 89a7208. You can monitor the build here. Update: The results are in! |
|
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Hey @jakebailey, the results of running the DT tests are ready. |
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
gabritto
requested changes
Apr 5, 2024
src/compiler/checker.ts
Outdated
| @@ -20888,6 +20889,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| } | |||
| return Ternary.False; | |||
| } | |||
| else if (isThisTypePredicate(targetTypePredicate)) { | |||
| result &= compareTypes(sourceReturnType, targetReturnType, reportErrors); | |||
There was a problem hiding this comment.
That doesn't look right. We don't consider a function with a boolean return type assignable to a function with an identifier type predicate, as the code above implies. So I think instead of adding this change, what we want to do is change the condition above to also account for this type predicates: they should behave the same as identifier type predicates.
There was a problem hiding this comment.
Updated. However, it could potentially break some seemingly innocent code.
interface LineCollection {
isLeaft(): this is LineLeaf;
}
class LineNode implements LineCollection {
isLeaf() {
return false;
}
}| !!! error TS2416: Type '() => void' is not assignable to type '() => boolean'. | ||
| !!! error TS2416: Type 'void' is not assignable to type 'boolean'. | ||
|
|
||
| method3() { // should ok |
gabritto
approved these changes
Apr 8, 2024
| @@ -591,7 +591,7 @@ export class LineNode implements LineCollection { | |||
| if (children.length) this.updateCounts(); | |||
| } | |||
|
|
|||
| isLeaf() { | |||
| isLeaf(): this is LineLeaf { | |||
|
@typescript-bot test it |
|
Hey @gabritto, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: vinyl-file Package: vinyl Package: winjs |
|
@gabritto Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@gabritto Here are the results of running the user tests comparing Everything looks good! |
|
I'm guessing this PR breaks |
|
@gabritto Here are the results of running the top 400 repos comparing Something interesting changed - please have a look. Details
|
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57103