Skip to content

Pr issue 57087 - fix for relating (e.g. satisfies) function overloads to intersection specifications #57395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4b5310c
57087 src only (no new tests), only checkJsxGenericTagHasCorrectInfer…
craigphicks Feb 13, 2024
9d92464
added test files issue-57087-merged.ts issue-57087-eopt-merged.ts
craigphicks Feb 13, 2024
20916fc
57087 old source running new tests
craigphicks Feb 13, 2024
18f8b04
57087 new source running new tests
craigphicks Feb 13, 2024
e35d153
57087 lint checker.ts
craigphicks Feb 13, 2024
697ffe4
npx dprint fmt src/compiler/checker.ts
craigphicks Feb 13, 2024
93d52a9
if reportErrors===true and checkFunctionRelatedToIntersection falls, …
craigphicks Feb 13, 2024
50e42d5
npx dprint check src/compiler/checker.ts ok
craigphicks Feb 13, 2024
4677153
cleanup
craigphicks Feb 13, 2024
79a4a3c
cleanup
craigphicks Feb 13, 2024
26bd34a
cleanup
craigphicks Feb 13, 2024
b13708d
passing runtests
craigphicks Feb 15, 2024
96098be
lint;fmt
craigphicks Feb 15, 2024
d88fd4d
57087 src
craigphicks Feb 22, 2024
a338832
tests remove -57087 tests
craigphicks Feb 22, 2024
8b10d2e
tests revert to origin state
craigphicks Feb 22, 2024
7b11aa7
old src + new test
craigphicks Feb 22, 2024
b21a8a6
old src + new test results (+tests/cases/compiler/checkOverloadsRelat…
craigphicks Feb 22, 2024
3809770
new checker but its not passing checkOverloadsRelatedToIntersection.t…
craigphicks Feb 22, 2024
06b7d35
new checker + new test (checkOverloadsRelatedToIntersection) and results
craigphicks Feb 22, 2024
ae43987
fixed format of comment
craigphicks Feb 22, 2024
2d54894
fixed format of diagnostic
craigphicks Feb 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
199 changes: 193 additions & 6 deletions src/compiler/checker.ts

Large diffs are not rendered by default.

8 changes: 8 additions & 0 deletions src/compiler/diagnosticMessages.json
Original file line number Diff line number Diff line change
Expand Up @@ -7988,5 +7988,13 @@
"'await using' statements cannot be used inside a class static block.": {
"category": "Error",
"code": 18054
},
"There is no signature in type {0} such that its parameters are assignable to the parameters of signature {1}": {
"category": "Error",
"code": 18055
},
"Parameters of signature {0} are not assignable to the parameters of any signature in type {1}": {
"category": "Error",
"code": 18056
}
}

Large diffs are not rendered by default.

Loading