Fix tslib resolutions #58451

andrewbranch · 2024-05-06T21:38:33Z

Fixes #57688
Also discovered and fixed #58450 in the process

DanielRosenwasser · 2024-05-06T21:51:01Z

idk which perf tests use tslib, but

typescript-bot · 2024-05-06T21:51:04Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

jakebailey · 2024-05-06T21:54:03Z

I'm not sure any of them do, actually...

andrewbranch · 2024-05-06T21:57:53Z

@typescript-bot test top400

typescript-bot · 2024-05-06T21:57:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results

typescript-bot · 2024-05-06T22:28:08Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,273	_50,273	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,019k (± 1.02%)}	_{192,792k (± 0.76%)}	_~	_192,152k	_195,777k	_{p=0.298 n=6}
_{Parse Time}	_{1.55s (± 1.90%)}	_{1.57s (± 0.77%)}	_~	_1.55s	_1.58s	_{p=0.286 n=6}
_{Bind Time}	_{0.87s (± 0.97%)}	_{0.86s (± 1.36%)}	_~	_0.85s	_0.88s	_{p=0.547 n=6}
_{Check Time}	_{11.27s (± 0.35%)}	_{11.29s (± 0.22%)}	_~	_11.26s	_11.33s	_{p=0.520 n=6}
_{Emit Time}	_{3.16s (± 0.58%)}	_{3.14s (± 0.55%)}	_~	_3.11s	_3.16s	_{p=0.119 n=6}
_{Total Time}	_{16.84s (± 0.18%)}	_{16.85s (± 0.24%)}	_~	_16.79s	_16.90s	_{p=0.627 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,322	_945,322	_~	_~	_~	_{p=1.000 n=6}
_Types	_408,110	_408,110	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,784k (± 0.00%)}	_{1,222,849k (± 0.01%)}	_~	_1,222,769k	_1,222,907k	_{p=0.093 n=6}
_{Parse Time}	_{8.07s (± 0.53%)}	_{8.12s (± 0.74%)}	_~	_8.07s	_8.20s	_{p=0.170 n=6}
_{Bind Time}	_{2.24s (± 0.62%)}	_{2.24s (± 0.46%)}	_~	_2.23s	_2.26s	_{p=0.365 n=6}
_{Check Time}	_{36.67s (± 0.39%)}	_{36.71s (± 0.55%)}	_~	_36.46s	_37.04s	_{p=0.748 n=6}
_{Emit Time}	_{17.43s (± 0.40%)}	_{17.48s (± 0.27%)}	_~	_17.40s	_17.54s	_{p=0.146 n=6}
_{Total Time}	_{64.39s (± 0.31%)}	_{64.56s (± 0.42%)}	_~	_64.26s	_64.96s	_{p=0.297 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,957,194	_1,957,194	_~	_~	_~	_{p=1.000 n=6}
_Types	_676,642	_676,642	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,765,628k (± 0.00%)}	_{1,765,614k (± 0.00%)}	_~	_1,765,536k	_1,765,686k	_{p=0.521 n=6}
_{Parse Time}	_{9.80s (± 0.26%)}	_{9.76s (± 0.70%)}	_~	_9.68s	_9.88s	_{p=0.107 n=6}
_{Bind Time}	_{3.33s (± 0.74%)}	_{3.35s (± 0.65%)}	_~	_3.32s	_3.38s	_{p=0.145 n=6}
_{Check Time}	_{81.27s (± 0.46%)}	_{81.48s (± 0.42%)}	_~	_80.87s	_81.72s	_{p=0.296 n=6}
_{Emit Time}	_0.20s	_0.20s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{94.61s (± 0.41%)}	_{94.79s (± 0.41%)}	_~	_94.09s	_95.14s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,450	_1,217,457	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,040	_259,046	_{+6 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,328,750k (± 0.03%)}	_{2,328,129k (± 0.04%)}	_~	_2,327,585k	_2,330,081k	_{p=0.128 n=6}
_{Parse Time}	_{7.44s (± 0.78%)}	_{7.50s (± 0.96%)}	_~	_7.39s	_7.59s	_{p=0.195 n=6}
_{Bind Time}	_{2.73s (± 0.33%)}	_{2.73s (± 0.61%)}	_~	_2.71s	_2.75s	_{p=0.934 n=6}
_{Check Time}	_{48.65s (± 0.61%)}	_{48.72s (± 0.36%)}	_~	_48.47s	_48.96s	_{p=0.378 n=6}
_{Emit Time}	_{3.87s (± 3.21%)}	_{3.96s (± 4.06%)}	_~	_3.70s	_4.20s	_{p=0.298 n=6}
_{Total Time}	_{62.70s (± 0.63%)}	_{62.92s (± 0.33%)}	_~	_62.58s	_63.12s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,217,450	_1,217,457	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,040	_259,046	_{+6 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,403,709k (± 0.04%)}	_{2,404,149k (± 0.02%)}	_~	_2,403,591k	_2,404,725k	_{p=0.689 n=6}
_{Parse Time}	_{7.74s (± 1.32%)}	_{7.74s (± 1.19%)}	_~	_7.67s	_7.91s	_{p=0.575 n=6}
_{Bind Time}	_{2.45s (± 0.54%)}	_{2.46s (± 0.99%)}	_~	_2.43s	_2.50s	_{p=0.375 n=6}
_{Check Time}	_{49.38s (± 0.18%)}	_{49.37s (± 0.18%)}	_~	_49.23s	_49.49s	_{p=0.873 n=6}
_{Emit Time}	_{3.85s (± 2.85%)}	_{3.79s (± 1.56%)}	_~	_3.69s	_3.86s	_{p=0.229 n=6}
_{Total Time}	_{63.44s (± 0.27%)}	_{63.37s (± 0.16%)}	_~	_63.23s	_63.49s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,369	_256,376	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,483	_104,489	_{+6 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{424,990k (± 0.00%)}	_{424,987k (± 0.01%)}	_~	_424,962k	_425,017k	_{p=1.000 n=6}
_{Parse Time}	_{4.16s (± 0.75%)}	_{4.15s (± 0.58%)}	_~	_4.11s	_4.17s	_{p=0.747 n=6}
_{Bind Time}	_{1.59s (± 1.32%)}	_{1.58s (± 1.16%)}	_~	_1.55s	_1.60s	_{p=1.000 n=6}
_{Check Time}	_{21.90s (± 0.19%)}	_{21.88s (± 0.28%)}	_~	_21.78s	_21.96s	_{p=0.421 n=6}
_{Emit Time}	_{1.73s (± 1.34%)}	_{1.73s (± 1.43%)}	_~	_1.69s	_1.76s	_{p=0.808 n=6}
_{Total Time}	_{29.38s (± 0.20%)}	_{29.34s (± 0.17%)}	_~	_29.25s	_29.41s	_{p=0.377 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,826	_224,826	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,115	_94,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,014k (± 0.04%)}	_{370,048k (± 0.02%)}	_~	_369,926k	_370,119k	_{p=0.377 n=6}
_{Parse Time}	_{3.52s (± 0.50%)}	_{3.51s (± 0.66%)}	_~	_3.48s	_3.54s	_{p=0.566 n=6}
_{Bind Time}	_{1.93s (± 1.11%)}	_{1.94s (± 1.25%)}	_~	_1.91s	_1.98s	_{p=0.808 n=6}
_{Check Time}	_{19.31s (± 0.46%)}	_{19.32s (± 0.56%)}	_~	_19.20s	_19.50s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.76s (± 0.41%)}	_{24.77s (± 0.48%)}	_~	_24.64s	_24.98s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,807,082	_2,807,082	_~	_~	_~	_{p=1.000 n=6}
_Types	_952,919	_952,919	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,978,795k (± 0.00%)}	_{2,978,744k (± 0.00%)}	_~	_2,978,666k	_2,978,968k	_{p=0.575 n=6}
_{Parse Time}	_{11.45s (± 0.16%)}	_{11.46s (± 0.17%)}	_~	_11.44s	_11.48s	_{p=0.684 n=6}
_{Bind Time}	_{3.43s (± 0.24%)}	_{3.44s (± 0.22%)}	_~	_3.43s	_3.45s	_{p=0.120 n=6}
_{Check Time}	_{63.37s (± 2.50%)}	_{63.59s (± 2.51%)}	_~	_62.50s	_66.81s	_{p=0.173 n=6}
_{Emit Time}	_{19.63s (± 6.90%)}	_{19.77s (± 6.86%)}	_~	_17.01s	_20.51s	_{p=0.149 n=6}
_{Total Time}	_{97.89s (± 0.32%)}	_{98.26s (± 0.32%)}	_~	_97.81s	_98.73s	_{p=0.065 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,864	_265,864	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,449	_108,449	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,463k (± 0.02%)}	_{410,443k (± 0.01%)}	_~	_410,364k	_410,492k	_{p=0.936 n=6}
_{Parse Time}	_{4.78s (± 0.69%)}	_{4.79s (± 0.63%)}	_~	_4.76s	_4.83s	_{p=0.808 n=6}
_{Bind Time}	_{2.07s (± 0.86%)}	_{2.07s (± 0.61%)}	_~	_2.05s	_2.08s	_{p=0.934 n=6}
_{Check Time}	_{21.01s (± 0.27%)}	_{20.99s (± 0.14%)}	_~	_20.95s	_21.04s	_{p=0.572 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.86s (± 0.25%)}	_{27.86s (± 0.20%)}	_~	_27.76s	_27.92s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,961	_524,961	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,070	_179,070	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,833k (± 0.02%)}	_{462,870k (± 0.03%)}	_~	_462,763k	_463,077k	_{p=0.575 n=6}
_{Parse Time}	_{3.10s (± 0.87%)}	_{3.10s (± 0.47%)}	_~	_3.08s	_3.12s	_{p=0.744 n=6}
_{Bind Time}	_{1.17s (± 0.90%)}	_{1.17s (± 1.47%)}	_~	_1.15s	_1.19s	_{p=0.566 n=6}
_{Check Time}	_{18.17s (± 0.46%)}	_{18.12s (± 0.47%)}	_~	_18.01s	_18.21s	_{p=0.471 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.43s (± 0.29%)}	_{22.39s (± 0.30%)}	_~	_22.31s	_22.48s	_{p=0.228 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,296ms (± 0.60%)}	_{2,288ms (± 0.68%)}	_~	_2,267ms	_2,306ms	_{p=0.296 n=6}
_{Req 2 - geterr}	_{5,126ms (± 0.50%)}	_{5,136ms (± 0.50%)}	_~	_5,103ms	_5,171ms	_{p=0.688 n=6}
_{Req 3 - references}	_{283ms (± 0.39%)}	_{285ms (± 1.09%)}	_~	_282ms	_291ms	_{p=0.112 n=6}
_{Req 4 - navto}	_{225ms (± 0.54%)}	_{226ms (± 0.77%)}	_~	_224ms	_229ms	_{p=0.325 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (±10.30%)}	_{80ms (± 8.19%)}	_~	_77ms	_93ms	_{p=0.282 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,439ms (± 0.30%)}	_{2,421ms (± 0.62%)}	_~	_2,402ms	_2,441ms	_{p=0.093 n=6}
_{Req 2 - geterr}	_{3,832ms (± 0.25%)}	_{3,833ms (± 0.12%)}	_~	_3,829ms	_3,841ms	_{p=0.748 n=6}
_{Req 3 - references}	_{295ms (± 0.28%)}	_{295ms (± 0.33%)}	_~	_294ms	_296ms	_{p=0.273 n=6}
_{Req 4 - navto}	_{227ms (± 0.33%)}	_227ms	_~	_~	_~	_{p=0.598 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 6.96%)}	_{75ms (± 5.61%)}	_~	_72ms	_83ms	_{p=0.718 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,129ms (± 0.30%)}	_{5,115ms (± 0.56%)}	_~	_5,087ms	_5,160ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{1,132ms (± 0.83%)}	_{1,133ms (± 0.95%)}	_~	_1,122ms	_1,152ms	_{p=0.936 n=6}
_{Req 3 - references}	_{86ms (± 1.43%)}	_{85ms (± 1.57%)}	_~	_83ms	_86ms	_{p=0.383 n=6}
_{Req 4 - navto}	_{450ms (± 1.50%)}	_{450ms (± 0.65%)}	_~	_447ms	_455ms	_{p=0.326 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{846ms (± 1.04%)}	_{848ms (± 1.62%)}	_~	_834ms	_874ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{156.96ms (± 0.18%)}	_{156.97ms (± 0.18%)}	_~	_155.89ms	_160.90ms	_{p=0.662 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{240.24ms (± 0.15%)}	_{240.48ms (± 0.14%)}	_{+0.24ms (+ 0.10%)}	_239.10ms	_246.79ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{236.28ms (± 0.14%)}	_{236.33ms (± 0.15%)}	_~	_234.68ms	_240.53ms	_{p=0.184 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{236.07ms (± 0.17%)}	_{235.77ms (± 0.16%)}	_{-0.30ms (- 0.13%)}	_234.20ms	_238.58ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-06T23:42:57Z

@andrewbranch Here are the results of running the top 400 repos comparing main and refs/pull/58451/merge:

Everything looks good!

sheetalkamat

looks good

src/compiler/program.ts

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

Fix tslib resolutions

246f74b

typescript-bot assigned andrewbranch May 6, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 6, 2024

andrewbranch requested a review from rbuckton May 6, 2024 21:39

andrewbranch requested review from jakebailey and gabritto May 7, 2024 15:26

jakebailey approved these changes May 7, 2024

View reviewed changes

sheetalkamat reviewed May 7, 2024

View reviewed changes

src/compiler/program.ts Outdated Show resolved Hide resolved

Improve condition order

598bb32

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

andrewbranch merged commit 14b4529 into microsoft:main May 7, 2024
28 checks passed

andrewbranch deleted the bug/58325 branch May 7, 2024 18:28

andrewbranch mentioned this pull request Jul 9, 2024

Added affectsSourceFile to importHelpers and jsxImportSource #59195

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tslib resolutions #58451

Fix tslib resolutions #58451

andrewbranch commented May 6, 2024

DanielRosenwasser commented May 6, 2024

typescript-bot commented May 6, 2024 •

edited

Loading

jakebailey commented May 6, 2024

andrewbranch commented May 6, 2024

typescript-bot commented May 6, 2024 •

edited

Loading

typescript-bot commented May 6, 2024

tsc

tsserver

startup

typescript-bot commented May 6, 2024

sheetalkamat left a comment

Fix tslib resolutions #58451

Fix tslib resolutions #58451

Conversation

andrewbranch commented May 6, 2024

DanielRosenwasser commented May 6, 2024

typescript-bot commented May 6, 2024 • edited Loading

jakebailey commented May 6, 2024

andrewbranch commented May 6, 2024

typescript-bot commented May 6, 2024 • edited Loading

typescript-bot commented May 6, 2024

tsc

tsserver

startup

typescript-bot commented May 6, 2024

sheetalkamat left a comment

Choose a reason for hiding this comment

typescript-bot commented May 6, 2024 •

edited

Loading

typescript-bot commented May 6, 2024 •

edited

Loading