Allow `this` when it appears in `this is T` positions #59310

RyanCavanaugh · 2024-07-16T21:48:42Z

Fixes #59252

Andarist · 2024-07-16T21:59:18Z

This has quite some commits that likely shouldn't be included in this PR :P

Fixes microsoft#59252

src/compiler/checker.ts

See Daniel's comment

RyanCavanaugh · 2024-07-23T19:38:16Z

@typescript-bot test this

typescript-bot · 2024-07-23T19:38:20Z

This PR is not mergeable. Please resolve conflicts before running tests.

# Conflicts: # tests/baselines/reference/mappedTypeWithAsClauseAndLateBoundProperty2.js

RyanCavanaugh · 2024-07-23T19:42:08Z

@typescript-bot test this

typescript-bot · 2024-07-23T19:42:12Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-23T20:02:54Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-23T20:04:15Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/59310/merge:

Everything looks good!

typescript-bot · 2024-07-23T20:25:23Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,160k (± 1.04%)}	_{192,898k (± 0.76%)}	_~	_192,281k	_195,878k	_{p=0.128 n=6}
_{Parse Time}	_{1.58s (± 0.67%)}	_{1.58s (± 1.13%)}	_~	_1.56s	_1.61s	_{p=0.805 n=6}
_{Bind Time}	_{0.86s (± 0.88%)}	_{0.86s (± 1.59%)}	_~	_0.84s	_0.88s	_{p=0.672 n=6}
_{Check Time}	_{11.31s (± 0.49%)}	_{11.36s (± 0.64%)}	_~	_11.27s	_11.44s	_{p=0.229 n=6}
_{Emit Time}	_{3.27s (± 0.71%)}	_{3.25s (± 1.14%)}	_~	_3.21s	_3.31s	_{p=0.224 n=6}
_{Total Time}	_{17.02s (± 0.24%)}	_{17.04s (± 0.42%)}	_~	_16.93s	_17.13s	_{p=0.295 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,089k (± 0.00%)}	_{1,221,080k (± 0.00%)}	_~	_1,221,043k	_1,221,111k	_{p=0.689 n=6}
_{Parse Time}	_{7.87s (± 0.75%)}	_{7.84s (± 0.73%)}	_~	_7.79s	_7.95s	_{p=0.296 n=6}
_{Bind Time}	_{2.20s (± 0.78%)}	_{2.19s (± 0.29%)}	_~	_2.18s	_2.20s	_{p=0.557 n=6}
_{Check Time}	_{36.24s (± 0.37%)}	_{36.25s (± 0.45%)}	_~	_35.99s	_36.51s	_{p=0.259 n=6}
_{Emit Time}	_{17.71s (± 0.22%)}	_{17.81s (± 0.72%)}	_~	_17.58s	_17.92s	_{p=0.065 n=6}
_{Total Time}	_{64.02s (± 0.28%)}	_{64.08s (± 0.42%)}	_~	_63.79s	_64.53s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,276,404	_2,276,404	_~	_~	_~	_{p=1.000 n=6}
_Types	_949,156	_949,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,208,338k (± 0.00%)}	_{2,208,302k (± 0.00%)}	_~	_2,208,215k	_2,208,336k	_{p=0.173 n=6}
_{Parse Time}	_{7.82s (± 0.22%)}	_{7.84s (± 0.30%)}	_~	_7.81s	_7.87s	_{p=0.328 n=6}
_{Bind Time}	_{2.74s (± 0.38%)}	_{2.74s (± 0.55%)}	_~	_2.72s	_2.75s	_{p=0.564 n=6}
_{Check Time}	_{86.38s (± 0.20%)}	_{86.32s (± 0.49%)}	_~	_85.84s	_86.96s	_{p=0.689 n=6}
_{Emit Time}	_{0.17s (± 4.71%)}	_{0.17s (± 2.98%)}	_~	_0.17s	_0.18s	_{p=0.929 n=6}
_{Total Time}	_{97.11s (± 0.18%)}	_{97.07s (± 0.45%)}	_~	_96.60s	_97.75s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,162	_1,231,162	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,119	_266,119	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,467,598k (± 7.44%)}	_{2,527,262k (±11.80%)}	_~	_2,348,322k	_3,062,729k	_{p=0.936 n=6}
_{Parse Time}	_{6.08s (± 0.75%)}	_{6.09s (± 1.09%)}	_~	_6.02s	_6.21s	_{p=0.809 n=6}
_{Bind Time}	_{2.26s (± 0.66%)}	_{2.27s (± 1.17%)}	_~	_2.24s	_2.31s	_{p=0.872 n=6}
_{Check Time}	_{40.62s (± 0.66%)}	_{40.81s (± 0.65%)}	_~	_40.37s	_41.18s	_{p=0.336 n=6}
_{Emit Time}	_{3.98s (± 1.64%)}	_{3.91s (± 1.55%)}	_~	_3.82s	_4.00s	_{p=0.109 n=6}
_{Total Time}	_{52.94s (± 0.50%)}	_{53.08s (± 0.57%)}	_~	_52.55s	_53.46s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,162	_1,231,162	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,119	_266,119	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,894k (± 0.05%)}	_{2,423,413k (± 0.02%)}	_~	_2,422,444k	_2,424,099k	_{p=0.689 n=6}
_{Parse Time}	_{6.30s (± 0.76%)}	_{6.34s (± 1.19%)}	_~	_6.23s	_6.43s	_{p=0.377 n=6}
_{Bind Time}	_{2.04s (± 1.25%)}	_{2.03s (± 0.67%)}	_~	_2.01s	_2.05s	_{p=0.684 n=6}
_{Check Time}	_{41.42s (± 0.26%)}	_{41.45s (± 0.37%)}	_~	_41.19s	_41.62s	_{p=0.810 n=6}
_{Emit Time}	_{3.94s (± 1.31%)}	_{3.97s (± 1.64%)}	_~	_3.89s	_4.05s	_{p=0.630 n=6}
_{Total Time}	_{53.71s (± 0.13%)}	_{53.79s (± 0.33%)}	_~	_53.53s	_54.04s	_{p=0.261 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,215	_259,215	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,867	_105,867	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,634k (± 0.03%)}	_{429,614k (± 0.03%)}	_~	_429,520k	_429,876k	_{p=0.810 n=6}
_{Parse Time}	_{3.35s (± 0.76%)}	_{3.34s (± 0.69%)}	_~	_3.31s	_3.38s	_{p=0.511 n=6}
_{Bind Time}	_{1.32s (± 0.91%)}	_{1.31s (± 1.63%)}	_~	_1.28s	_1.33s	_{p=0.418 n=6}
_{Check Time}	_{18.04s (± 0.57%)}	_{18.07s (± 0.47%)}	_~	_17.96s	_18.17s	_{p=0.810 n=6}
_{Emit Time}	_{1.64s (± 1.26%)}	_{1.62s (± 1.59%)}	_~	_1.60s	_1.66s	_{p=0.164 n=6}
_{Total Time}	_{24.36s (± 0.50%)}	_{24.35s (± 0.33%)}	_~	_24.25s	_24.46s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,157k (± 0.05%)}	_{370,124k (± 0.05%)}	_~	_369,928k	_370,311k	_{p=0.575 n=6}
_{Parse Time}	_{2.76s (± 0.74%)}	_{2.77s (± 0.82%)}	_~	_2.73s	_2.79s	_{p=0.514 n=6}
_{Bind Time}	_{1.58s (± 0.77%)}	_{1.58s (± 0.77%)}	_~	_1.57s	_1.60s	_{p=1.000 n=6}
_{Check Time}	_{15.66s (± 0.28%)}	_{15.66s (± 0.27%)}	_~	_15.63s	_15.73s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.00s (± 0.27%)}	_{20.01s (± 0.32%)}	_~	_19.93s	_20.09s	_{p=0.572 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,986,659	_2,986,659	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,027,499	_1,027,499	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,111,152k (± 0.00%)}	_{3,111,141k (± 0.00%)}	_~	_3,111,068k	_3,111,225k	_{p=0.873 n=6}
_{Parse Time}	_{17.03s (± 0.39%)}	_{16.99s (± 0.23%)}	_~	_16.92s	_17.03s	_{p=0.171 n=6}
_{Bind Time}	_{5.25s (± 2.03%)}	_{5.26s (± 2.07%)}	_~	_5.20s	_5.48s	_{p=0.419 n=6}
_{Check Time}	_{96.31s (± 0.39%)}	_{96.20s (± 0.37%)}	_~	_95.80s	_96.75s	_{p=0.689 n=6}
_{Emit Time}	_{24.93s (± 0.51%)}	_{25.00s (± 0.43%)}	_~	_24.86s	_25.14s	_{p=0.229 n=6}
_{Total Time}	_{143.52s (± 0.21%)}	_{143.45s (± 0.21%)}	_~	_143.18s	_143.95s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,603	_267,603	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,105	_109,105	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,328k (± 0.02%)}	_{412,319k (± 0.01%)}	_~	_412,258k	_412,371k	_{p=0.689 n=6}
_{Parse Time}	_{3.84s (± 0.71%)}	_{3.85s (± 0.62%)}	_~	_3.82s	_3.89s	_{p=0.935 n=6}
_{Bind Time}	_{1.72s (± 0.48%)}	_{1.71s (± 0.71%)}	_~	_1.70s	_1.73s	_{p=1.000 n=6}
_{Check Time}	_{16.87s (± 0.28%)}	_{16.80s (± 0.47%)}	_~	_16.70s	_16.92s	_{p=0.228 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.43s (± 0.28%)}	_{22.37s (± 0.32%)}	_~	_22.29s	_22.46s	_{p=0.149 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,803	_511,803	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,088	_162,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{449,207k (± 0.07%)}	_{449,214k (± 0.07%)}	_~	_448,585k	_449,460k	_{p=0.810 n=6}
_{Parse Time}	_{2.63s (± 0.44%)}	_{2.63s (± 0.57%)}	_~	_2.61s	_2.64s	_{p=1.000 n=6}
_{Bind Time}	_{0.97s (± 1.60%)}	_{0.97s (± 0.65%)}	_~	_0.96s	_0.98s	_{p=0.553 n=6}
_{Check Time}	_{14.58s (± 0.54%)}	_{14.59s (± 0.32%)}	_~	_14.55s	_14.66s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.18s (± 0.45%)}	_{18.19s (± 0.24%)}	_~	_18.15s	_18.26s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-23T21:25:19Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59310/merge:

Everything looks good!

typescript-bot assigned RyanCavanaugh Jul 16, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 16, 2024

RyanCavanaugh marked this pull request as draft July 16, 2024 21:54

Allow this when it appears in this is T positions

54a83b9

Fixes microsoft#59252

RyanCavanaugh force-pushed the fix59252 branch from 8fb70af to 54a83b9 Compare July 16, 2024 22:02

jakebailey reviewed Jul 16, 2024

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

Only applies to left operand

08a65b1

RyanCavanaugh marked this pull request as ready for review July 17, 2024 17:33

jakebailey previously approved these changes Jul 17, 2024

View reviewed changes

DanielRosenwasser reviewed Jul 17, 2024

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

There's no reason to call this function here

a26f435

Merge remote-tracking branch 'upstream/main' into fix59252

094509a

# Conflicts: # tests/baselines/reference/mappedTypeWithAsClauseAndLateBoundProperty2.js

jakebailey approved these changes Aug 2, 2024

View reviewed changes

RyanCavanaugh merged commit ffb9585 into microsoft:main Aug 2, 2024
32 checks passed

RyanCavanaugh deleted the fix59252 branch August 2, 2024 17:38

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `this` when it appears in `this is T` positions #59310

Allow `this` when it appears in `this is T` positions #59310

RyanCavanaugh commented Jul 16, 2024

Andarist commented Jul 16, 2024

RyanCavanaugh commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

RyanCavanaugh commented Jul 23, 2024

typescript-bot commented Jul 23, 2024 •

edited

Loading

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

tsc

typescript-bot commented Jul 23, 2024

Allow this when it appears in this is T positions #59310

Allow this when it appears in this is T positions #59310

Conversation

RyanCavanaugh commented Jul 16, 2024

Andarist commented Jul 16, 2024

RyanCavanaugh commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

RyanCavanaugh commented Jul 23, 2024

typescript-bot commented Jul 23, 2024 • edited Loading

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

tsc

typescript-bot commented Jul 23, 2024

Allow `this` when it appears in `this is T` positions #59310

Allow `this` when it appears in `this is T` positions #59310

typescript-bot commented Jul 23, 2024 •

edited

Loading