Skip markLinkedReferences import elision walk entirely in some common cases #59398

weswigham · 2024-07-23T18:09:08Z

This should just improve performance of js->js emit with noCheck on.

… cases

…s only apparent when the linked references pass is skipped

weswigham · 2024-07-23T20:40:38Z

@typescript-bot test this
@typescript-bot perf test this

typescript-bot · 2024-07-23T20:40:41Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

weswigham · 2024-07-23T21:00:33Z

src/compiler/checker.ts

-                    checkIdentifierCalculateNodeCheckFlags(node, s);
+            nodeLinks.calculatedFlags |= NodeCheckFlags.ConstructorReference;
+            if (isIdentifier(node)) {
+                nodeLinks.calculatedFlags |= NodeCheckFlags.BlockScopedBindingInLoop | NodeCheckFlags.CapturedBlockScopedBinding; // Can't set on all arbitrary nodes (these nodes have this flag set by `checkSingleBlockScopeBinding` only)


The references walk was implicitly calling checkComputedPropertyName on the computed properties, which was calculating the CapturedBlockScopedBinding and BlockScopedBindingInLoop flag on them, which was hiding the fact that preemptively setting these computed flags on all nodes we walk while walking only identifiers would block us from calculating them properly for computed and private names. So that's fixed here, too.

jakebailey · 2024-07-23T21:02:09Z

src/compiler/emitter.ts

@@ -961,6 +961,7 @@ export function emitFiles(
    }

    function markLinkedReferences(file: SourceFile) {
+        if (ts.isSourceFileJS(file)) return; // JS files don't use reference calculations as they don't do import ellision, no need to calculate it


Hopefully we remember to remove this if/when decorator metadata becomes a thing again with non-experimental decorators, since preserving imports used for those types I think will end up mattering even in JS files (cross this issue with that other bug I fixed).

Actually, does this work for JSX files? or does this trigger that other bug where we don't realize that import "react" is going to happen?

e.g. should we copy the test from #59193 and make it a .jsx file?

In JSX files the import "react" we add to the output is injected by the emitter based on compiler options and doesn't depend on the refrenced-ness of the synthetic import thing in the checker (you can check pretty easily by seeing there's no resolver.isReferencedAliasDeclaration type calls in the jsx transform - only in the ts transform, and only if the file isn't JS).

But yeah, should circumstances change and shouldEmitAliasDeclaration in ts.ts changes, this'd need to change to match.

Fun fact: I tried skipping this walk for files with nothing in their .imports member, too (so no references to external modules), but tests showed that we still needed import elision calculation done even in files with no external imports, because local elision on export import a = b statements is done using the same logic and relies on this running to work. And there's no simple way to know if those are present without traversing the tree anyway. 🤷‍♂️ I could have done if (!length(file.imports) && !(file.transformFlags & TransformFlags.TypeScript)) return; (since export import = is TS syntax), but how many .ts files don't contain any typescript syntax - hardly seems worth it.

Ah, I guess it doesn't matter because we don't care about exact errors in this case, yeah.

typescript-bot · 2024-07-23T21:17:27Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,501k (± 0.94%)}	_{193,496k (± 0.96%)}	_~	_192,268k	_195,949k	_{p=0.689 n=6}
_{Parse Time}	_{1.31s (± 0.89%)}	_{1.30s (± 0.63%)}	_~	_1.29s	_1.31s	_{p=0.401 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.64%)}	_{9.53s (± 0.24%)}	_~	_9.49s	_9.55s	_{p=0.572 n=6}
_{Emit Time}	_{2.74s (± 0.81%)}	_{2.74s (± 0.55%)}	_~	_2.72s	_2.76s	_{p=0.620 n=6}
_{Total Time}	_{14.31s (± 0.49%)}	_{14.29s (± 0.18%)}	_~	_14.25s	_14.32s	_{p=0.374 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,164k (± 0.00%)}	_{1,221,140k (± 0.00%)}	_~	_1,221,073k	_1,221,178k	_{p=0.230 n=6}
_{Parse Time}	_{6.59s (± 0.31%)}	_{6.60s (± 0.45%)}	_~	_6.57s	_6.65s	_{p=0.624 n=6}
_{Bind Time}	_{1.86s (± 0.28%)}	_{1.86s (± 0.56%)}	_~	_1.84s	_1.87s	_{p=0.928 n=6}
_{Check Time}	_{31.05s (± 0.42%)}	_{31.11s (± 0.19%)}	_~	_31.01s	_31.17s	_{p=0.297 n=6}
_{Emit Time}	_{14.99s (± 0.69%)}	_{15.10s (± 0.57%)}	_~	_14.96s	_15.19s	_{p=0.126 n=6}
_{Total Time}	_{54.48s (± 0.36%)}	_{54.67s (± 0.17%)}	_~	_54.53s	_54.80s	_{p=0.066 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,276,404	_2,276,404	_~	_~	_~	_{p=1.000 n=6}
_Types	_949,156	_949,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,208,333k (± 0.00%)}	_{2,208,300k (± 0.00%)}	_~	_2,208,239k	_2,208,415k	_{p=0.230 n=6}
_{Parse Time}	_{7.85s (± 0.31%)}	_{7.83s (± 0.40%)}	_~	_7.79s	_7.87s	_{p=0.372 n=6}
_{Bind Time}	_{2.74s (± 0.36%)}	_{2.73s (± 0.60%)}	_~	_2.71s	_2.76s	_{p=0.315 n=6}
_{Check Time}	_{86.02s (± 0.32%)}	_{86.42s (± 0.49%)}	_~	_85.98s	_86.90s	_{p=0.230 n=6}
_{Emit Time}	_{0.17s (± 2.98%)}	_{0.17s (± 3.72%)}	_~	_0.16s	_0.18s	_{p=0.386 n=6}
_{Total Time}	_{96.78s (± 0.27%)}	_{97.16s (± 0.44%)}	_~	_96.68s	_97.62s	_{p=0.230 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,162	_1,231,162	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,119	_266,119	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,348,768k (± 0.01%)}	_{2,348,671k (± 0.01%)}	_~	_2,348,294k	_2,349,041k	_{p=0.810 n=6}
_{Parse Time}	_{5.08s (± 0.69%)}	_{5.09s (± 0.92%)}	_~	_5.02s	_5.15s	_{p=0.936 n=6}
_{Bind Time}	_{1.90s (± 0.96%)}	_{1.90s (± 0.79%)}	_~	_1.89s	_1.92s	_{p=1.000 n=6}
_{Check Time}	_{34.63s (± 0.26%)}	_{34.71s (± 0.36%)}	_~	_34.58s	_34.91s	_{p=0.199 n=6}
_{Emit Time}	_{3.34s (± 0.77%)}	_{3.32s (± 1.28%)}	_~	_3.27s	_3.36s	_{p=0.378 n=6}
_{Total Time}	_{44.97s (± 0.24%)}	_{45.02s (± 0.39%)}	_~	_44.84s	_45.31s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,162	_1,231,162	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,119	_266,119	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,423,087k (± 0.03%)}	_{2,541,819k (±11.41%)}	_~	_2,422,996k	_3,134,265k	_{p=0.378 n=6}
_{Parse Time}	_{6.30s (± 0.68%)}	_{6.37s (± 1.25%)}	_~	_6.26s	_6.48s	_{p=0.092 n=6}
_{Bind Time}	_{2.04s (± 0.57%)}	_{2.02s (± 0.97%)}	_~	_2.00s	_2.04s	_{p=0.050 n=6}
_{Check Time}	_{41.43s (± 0.47%)}	_{41.51s (± 0.46%)}	_~	_41.32s	_41.79s	_{p=0.298 n=6}
_{Emit Time}	_{4.00s (± 1.15%)}	_{3.99s (± 1.77%)}	_~	_3.91s	_4.07s	_{p=0.872 n=6}
_{Total Time}	_{53.78s (± 0.46%)}	_{53.87s (± 0.43%)}	_~	_53.64s	_54.17s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,215	_259,215	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,867	_105,867	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,592k (± 0.03%)}	_{429,629k (± 0.03%)}	_~	_429,500k	_429,820k	_{p=0.471 n=6}
_{Parse Time}	_{3.35s (± 0.79%)}	_{3.34s (± 0.58%)}	_~	_3.32s	_3.37s	_{p=0.627 n=6}
_{Bind Time}	_{1.32s (± 1.42%)}	_{1.32s (± 1.41%)}	_~	_1.29s	_1.34s	_{p=0.935 n=6}
_{Check Time}	_{18.05s (± 0.34%)}	_{18.02s (± 0.32%)}	_~	_17.96s	_18.12s	_{p=0.422 n=6}
_{Emit Time}	_{1.62s (± 2.09%)}	_{1.62s (± 2.57%)}	_~	_1.58s	_1.68s	_{p=0.872 n=6}
_{Total Time}	_{24.33s (± 0.34%)}	_{24.30s (± 0.31%)}	_~	_24.23s	_24.40s	_{p=0.470 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,994k (± 0.01%)}	_{370,016k (± 0.03%)}	_~	_369,866k	_370,119k	_{p=0.471 n=6}
_{Parse Time}	_{2.76s (± 0.93%)}	_{2.78s (± 0.68%)}	_~	_2.76s	_2.80s	_{p=0.329 n=6}
_{Bind Time}	_{1.58s (± 1.31%)}	_{1.58s (± 0.62%)}	_~	_1.57s	_1.59s	_{p=0.677 n=6}
_{Check Time}	_{15.66s (± 0.34%)}	_{15.62s (± 0.33%)}	_~	_15.54s	_15.68s	_{p=0.260 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.01s (± 0.42%)}	_{19.98s (± 0.30%)}	_~	_19.88s	_20.04s	_{p=0.686 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,986,659	_2,986,659	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,027,499	_1,027,499	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,111,106k (± 0.00%)}	_{3,111,123k (± 0.00%)}	_~	_3,111,051k	_3,111,238k	_{p=0.936 n=6}
_{Parse Time}	_{13.84s (± 0.31%)}	_{13.80s (± 0.28%)}	_~	_13.74s	_13.83s	_{p=0.125 n=6}
_{Bind Time}	_{4.29s (± 0.18%)}	_{4.30s (± 0.17%)}	_~	_4.29s	_4.31s	_{p=0.062 n=6}
_{Check Time}	_{79.38s (± 0.22%)}	_{79.04s (± 0.17%)}	_{-0.33s (- 0.42%)}	_78.88s	_79.20s	_{p=0.006 n=6}
_{Emit Time}	_{20.48s (± 0.54%)}	_{20.41s (± 0.44%)}	_~	_20.33s	_20.56s	_{p=0.378 n=6}
_{Total Time}	_{117.99s (± 0.20%)}	_{117.55s (± 0.18%)}	_{-0.45s (- 0.38%)}	_117.26s	_117.80s	_{p=0.016 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,603	_267,603	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,105	_109,105	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,374k (± 0.01%)}	_{412,346k (± 0.03%)}	_~	_412,207k	_412,544k	_{p=0.378 n=6}
_{Parse Time}	_{4.74s (± 0.26%)}	_{4.75s (± 0.44%)}	_~	_4.72s	_4.77s	_{p=0.624 n=6}
_{Bind Time}	_{2.13s (± 0.49%)}	_{2.13s (± 0.46%)}	_~	_2.11s	_2.14s	_{p=0.788 n=6}
_{Check Time}	_{20.77s (± 0.26%)}	_{20.78s (± 0.36%)}	_~	_20.71s	_20.92s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.64s (± 0.16%)}	_{27.65s (± 0.31%)}	_~	_27.59s	_27.82s	_{p=0.935 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,803	_511,803	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,088	_162,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{448,993k (± 0.08%)}	_{449,049k (± 0.08%)}	_~	_448,567k	_449,442k	_{p=1.000 n=6}
_{Parse Time}	_{3.17s (± 1.04%)}	_{3.16s (± 0.48%)}	_~	_3.14s	_3.18s	_{p=0.513 n=6}
_{Bind Time}	_{1.16s (± 0.44%)}	_{1.17s (± 0.90%)}	_~	_1.15s	_1.18s	_{p=0.794 n=6}
_{Check Time}	_{17.24s (± 0.39%)}	_{17.20s (± 0.38%)}	_~	_17.12s	_17.30s	_{p=0.375 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.57s (± 0.26%)}	_{21.53s (± 0.25%)}	_~	_21.46s	_21.61s	_{p=0.230 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-23T21:20:13Z

Hey @weswigham, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-23T21:26:41Z

@weswigham Here are the results of running the user tests with tsc comparing main and refs/pull/59398/merge:

Everything looks good!

typescript-bot · 2024-07-23T21:27:25Z

@weswigham
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,369k (± 0.96%)}	_{193,433k (± 0.93%)}	_~	_192,211k	_195,833k	_{p=0.810 n=6}
_{Parse Time}	_{1.95s (± 0.77%)}	_{1.96s (± 0.53%)}	_~	_1.95s	_1.98s	_{p=0.161 n=6}
_{Bind Time}	_{1.07s (± 1.09%)}	_{1.05s (± 1.20%)}	_{-0.02s (- 1.72%)}	_1.04s	_1.07s	_{p=0.041 n=6}
_{Check Time}	_{14.00s (± 0.57%)}	_{13.99s (± 0.41%)}	_~	_13.93s	_14.08s	_{p=0.520 n=6}
_{Emit Time}	_{4.16s (± 4.63%)}	_{4.00s (± 1.40%)}	_~	_3.89s	_4.05s	_{p=0.076 n=6}
_{Total Time}	_{21.18s (± 0.81%)}	_{20.99s (± 0.28%)}	_{-0.18s (- 0.87%)}	_20.90s	_21.06s	_{p=0.025 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,118k (± 0.00%)}	_{1,221,126k (± 0.00%)}	_~	_1,221,109k	_1,221,147k	_{p=0.936 n=6}
_{Parse Time}	_{7.86s (± 0.56%)}	_{7.88s (± 0.71%)}	_~	_7.80s	_7.97s	_{p=0.746 n=6}
_{Bind Time}	_{2.22s (± 0.78%)}	_{2.21s (± 0.74%)}	_~	_2.20s	_2.24s	_{p=0.086 n=6}
_{Check Time}	_{36.28s (± 0.25%)}	_{36.34s (± 0.40%)}	_~	_36.05s	_36.46s	_{p=0.148 n=6}
_{Emit Time}	_{17.77s (± 0.53%)}	_{17.85s (± 0.38%)}	_~	_17.76s	_17.95s	_{p=0.148 n=6}
_{Total Time}	_{64.13s (± 0.22%)}	_{64.28s (± 0.30%)}	_~	_63.91s	_64.48s	_{p=0.066 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,276,404	_2,276,404	_~	_~	_~	_{p=1.000 n=6}
_Types	_949,156	_949,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,208,279k (± 0.00%)}	_{2,208,316k (± 0.00%)}	_~	_2,208,201k	_2,208,376k	_{p=0.261 n=6}
_{Parse Time}	_{7.83s (± 0.36%)}	_{7.81s (± 0.28%)}	_~	_7.78s	_7.84s	_{p=0.331 n=6}
_{Bind Time}	_{2.73s (± 0.30%)}	_{2.73s (± 0.64%)}	_~	_2.72s	_2.76s	_{p=0.730 n=6}
_{Check Time}	_{85.87s (± 0.17%)}	_{85.61s (± 0.54%)}	_~	_85.13s	_86.29s	_{p=0.298 n=6}
_{Emit Time}	_{0.17s (± 4.89%)}	_{0.17s (± 4.38%)}	_~	_0.16s	_0.18s	_{p=0.306 n=6}
_{Total Time}	_{96.59s (± 0.13%)}	_{96.33s (± 0.47%)}	_~	_95.87s	_97.02s	_{p=0.199 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,162	_1,231,162	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,119	_266,119	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,349,643k (± 0.03%)}	_{2,349,990k (± 0.03%)}	_~	_2,349,446k	_2,351,441k	_{p=1.000 n=6}
_{Parse Time}	_{7.56s (± 0.86%)}	_{7.59s (± 1.10%)}	_~	_7.45s	_7.69s	_{p=0.471 n=6}
_{Bind Time}	_{2.79s (± 0.90%)}	_{2.79s (± 0.54%)}	_~	_2.77s	_2.81s	_{p=0.686 n=6}
_{Check Time}	_{50.45s (± 0.39%)}	_{50.47s (± 0.25%)}	_~	_50.33s	_50.69s	_{p=0.936 n=6}
_{Emit Time}	_{4.92s (± 2.01%)}	_{4.80s (± 1.70%)}	_~	_4.65s	_4.89s	_{p=0.093 n=6}
_{Total Time}	_{65.71s (± 0.40%)}	_{65.66s (± 0.20%)}	_~	_65.47s	_65.85s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,162	_1,231,162	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,119	_266,119	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,422,990k (± 0.02%)}	_{2,423,012k (± 0.02%)}	_~	_2,422,617k	_2,423,961k	_{p=0.936 n=6}
_{Parse Time}	_{5.29s (± 0.49%)}	_{5.30s (± 0.95%)}	_~	_5.25s	_5.38s	_{p=0.873 n=6}
_{Bind Time}	_{1.69s (± 0.45%)}	_{1.69s (± 0.58%)}	_~	_1.68s	_1.70s	_{p=0.554 n=6}
_{Check Time}	_{35.24s (± 0.19%)}	_{35.22s (± 0.24%)}	_~	_35.10s	_35.35s	_{p=0.873 n=6}
_{Emit Time}	_{3.35s (± 2.06%)}	_{3.34s (± 1.03%)}	_~	_3.29s	_3.37s	_{p=0.375 n=6}
_{Total Time}	_{45.58s (± 0.12%)}	_{45.55s (± 0.27%)}	_~	_45.42s	_45.76s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,215	_259,215	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,867	_105,867	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,604k (± 0.03%)}	_{429,804k (± 0.06%)}	_~	_429,551k	_430,079k	_{p=0.128 n=6}
_{Parse Time}	_{3.35s (± 0.45%)}	_{3.35s (± 0.72%)}	_~	_3.32s	_3.39s	_{p=0.871 n=6}
_{Bind Time}	_{1.32s (± 1.14%)}	_{1.33s (± 1.13%)}	_~	_1.30s	_1.34s	_{p=0.737 n=6}
_{Check Time}	_{18.07s (± 0.22%)}	_{18.07s (± 0.55%)}	_~	_17.97s	_18.25s	_{p=0.872 n=6}
_{Emit Time}	_{1.62s (± 1.97%)}	_{1.66s (± 1.52%)}	_{+0.04s (+ 2.57%)}	_1.62s	_1.69s	_{p=0.044 n=6}
_{Total Time}	_{24.36s (± 0.30%)}	_{24.41s (± 0.42%)}	_~	_24.26s	_24.55s	_{p=0.297 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,035k (± 0.03%)}	_{370,055k (± 0.03%)}	_~	_369,956k	_370,247k	_{p=0.810 n=6}
_{Parse Time}	_{2.28s (± 1.23%)}	_{2.30s (± 0.93%)}	_~	_2.27s	_2.32s	_{p=0.332 n=6}
_{Bind Time}	_{1.32s (± 1.47%)}	_{1.33s (± 1.30%)}	_~	_1.31s	_1.35s	_{p=0.557 n=6}
_{Check Time}	_{13.29s (± 0.35%)}	_{13.30s (± 0.33%)}	_~	_13.23s	_13.37s	_{p=0.629 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.90s (± 0.47%)}	_{16.93s (± 0.37%)}	_~	_16.88s	_17.03s	_{p=0.198 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,986,659	_2,986,659	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,027,499	_1,027,499	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,111,115k (± 0.00%)}	_{3,111,141k (± 0.00%)}	_~	_3,111,098k	_3,111,188k	_{p=0.336 n=6}
_{Parse Time}	_{11.58s (± 0.15%)}	_{11.57s (± 0.33%)}	_~	_11.51s	_11.61s	_{p=0.515 n=6}
_{Bind Time}	_{3.63s (± 2.16%)}	_{3.65s (± 2.57%)}	_~	_3.58s	_3.78s	_{p=0.805 n=6}
_{Check Time}	_{68.59s (± 0.47%)}	_{68.51s (± 0.39%)}	_~	_68.24s	_68.89s	_{p=0.810 n=6}
_{Emit Time}	_{17.36s (± 0.63%)}	_{17.40s (± 0.58%)}	_~	_17.26s	_17.52s	_{p=0.810 n=6}
_{Total Time}	_{101.17s (± 0.38%)}	_{101.13s (± 0.27%)}	_~	_100.83s	_101.47s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,603	_267,603	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,105	_109,105	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,341k (± 0.02%)}	_{412,364k (± 0.02%)}	_~	_412,285k	_412,487k	_{p=0.575 n=6}
_{Parse Time}	_{4.75s (± 0.46%)}	_{4.75s (± 0.69%)}	_~	_4.72s	_4.80s	_{p=0.517 n=6}
_{Bind Time}	_{2.12s (± 0.63%)}	_{2.12s (± 0.69%)}	_~	_2.10s	_2.14s	_{p=0.681 n=6}
_{Check Time}	_{20.77s (± 0.36%)}	_{20.76s (± 0.45%)}	_~	_20.68s	_20.93s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.64s (± 0.28%)}	_{27.62s (± 0.40%)}	_~	_27.52s	_27.83s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,803	_511,803	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,088	_162,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{449,122k (± 0.08%)}	_{449,092k (± 0.07%)}	_~	_448,690k	_449,347k	_{p=0.810 n=6}
_{Parse Time}	_{3.15s (± 0.71%)}	_{3.16s (± 0.79%)}	_~	_3.12s	_3.19s	_{p=0.466 n=6}
_{Bind Time}	_{1.16s (± 0.35%)}	_{1.16s (± 0.54%)}	_~	_1.15s	_1.17s	_{p=0.673 n=6}
_{Check Time}	_{17.22s (± 0.38%)}	_{17.21s (± 0.50%)}	_~	_17.12s	_17.36s	_{p=0.628 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.54s (± 0.31%)}	_{21.54s (± 0.33%)}	_~	_21.46s	_21.67s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,298ms (± 0.42%)}	_{2,297ms (± 0.35%)}	_~	_2,282ms	_2,306ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{5,156ms (± 0.14%)}	_{5,169ms (± 0.37%)}	_~	_5,135ms	_5,192ms	_{p=0.066 n=6}
_{Req 3 - references}	_{260ms (± 0.86%)}	_{261ms (± 0.78%)}	_~	_257ms	_262ms	_{p=0.390 n=6}
_{Req 4 - navto}	_{227ms (± 0.94%)}	_{227ms (± 0.51%)}	_~	_226ms	_229ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 5.92%)}	_{82ms (± 4.04%)}	_~	_77ms	_85ms	_{p=0.511 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,393ms (± 0.31%)}	_{2,424ms (± 1.51%)}	_~	_2,384ms	_2,468ms	_{p=0.226 n=6}
_{Req 2 - geterr}	_{3,887ms (± 0.26%)}	_{3,886ms (± 0.31%)}	_~	_3,869ms	_3,903ms	_{p=1.000 n=6}
_{Req 3 - references}	_{272ms (± 0.87%)}	_{273ms (± 0.50%)}	_~	_271ms	_275ms	_{p=0.370 n=6}
_{Req 4 - navto}	_{234ms (± 3.13%)}	_{230ms (± 2.19%)}	_~	_227ms	_240ms	_{p=0.801 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{70ms (± 3.99%)}	_{76ms (±10.97%)}	_~	_66ms	_84ms	_{p=0.465 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,177ms (± 0.19%)}	_{5,173ms (± 0.24%)}	_~	_5,158ms	_5,192ms	_{p=0.573 n=6}
_{Req 2 - geterr}	_{1,118ms (± 0.88%)}	_{1,115ms (± 0.94%)}	_~	_1,105ms	_1,132ms	_{p=0.686 n=6}
_{Req 3 - references}	_{85ms (± 4.20%)}	_{86ms (± 0.95%)}	_~	_84ms	_86ms	_{p=0.591 n=6}
_{Req 4 - navto}	_{443ms (± 0.31%)}	_{443ms (± 0.17%)}	_~	_442ms	_444ms	_{p=0.672 n=6}
_{Req 5 - completionInfo count}	_3,417	_3,417	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{816ms (± 1.57%)}	_{832ms (± 0.77%)}	_{+15ms (+ 1.88%)}	_820ms	_838ms	_{p=0.045 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{188.42ms (± 0.18%)}	_{188.31ms (± 0.16%)}	_{-0.11ms (- 0.06%)}	_186.68ms	_191.43ms	_{p=0.003 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.01ms (± 0.14%)}	_{231.13ms (± 0.16%)}	_{+0.12ms (+ 0.05%)}	_229.79ms	_236.78ms	_{p=0.005 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.74ms (± 0.16%)}	_{228.13ms (± 0.18%)}	_{+0.39ms (+ 0.17%)}	_226.71ms	_236.15ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{336.67ms (± 0.31%)}	_{336.88ms (± 0.31%)}	_{+0.22ms (+ 0.06%)}	_327.94ms	_344.81ms	_{p=0.010 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-23T22:39:06Z

@weswigham Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59398/merge:

Everything looks good!

weswigham · 2024-07-23T22:58:09Z

@typescript-bot cherry-pick this into release-5.5

typescript-bot · 2024-07-23T22:58:13Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this into release-5.5`	✅ Started	✅ Results

… cases (#59398)

typescript-bot · 2024-07-23T22:59:46Z

Hey, @weswigham! I've created #59404 for you.

jakebailey · 2024-07-23T23:04:35Z

5.5.4 already went out, are we doing a 5.5.5?

DanielRosenwasser · 2024-07-24T00:15:33Z

Yeah, I think we should try to unbreak that repro.

Skip markLinkedReferences import elision walk entirely in some common…

4260ea2

… cases

typescript-bot assigned weswigham Jul 23, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 23, 2024

weswigham mentioned this pull request Jul 23, 2024

RangeError: Maximum call stack size exceeded when building monaco (5.5.2) #59253

Closed

weswigham added 2 commits July 23, 2024 11:23

Curse you export import a = b statements, youve foiled me again

c3dcd4b

Fix issue with calculatedFlags in noCheck LazyCheckFlags visitor that…

9c73634

…s only apparent when the linked references pass is skipped

weswigham marked this pull request as ready for review July 23, 2024 20:58

weswigham requested a review from jakebailey July 23, 2024 20:58

weswigham commented Jul 23, 2024

View reviewed changes

weswigham requested a review from sandersn July 23, 2024 21:00

jakebailey reviewed Jul 23, 2024

View reviewed changes

jakebailey approved these changes Jul 23, 2024

View reviewed changes

weswigham merged commit 5bd4e00 into microsoft:main Jul 23, 2024
32 checks passed

typescript-bot pushed a commit that referenced this pull request Jul 23, 2024

Skip markLinkedReferences import elision walk entirely in some common…

e0701af

… cases (#59398)

typescript-bot mentioned this pull request Jul 23, 2024

🤖 Pick PR #59398 (Skip markLinkedReferences import el...) into release-5.5 #59404

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip markLinkedReferences import elision walk entirely in some common cases #59398

Skip markLinkedReferences import elision walk entirely in some common cases #59398

weswigham commented Jul 23, 2024 •

edited

Loading

weswigham commented Jul 23, 2024

typescript-bot commented Jul 23, 2024 •

edited

Loading

weswigham Jul 23, 2024

jakebailey Jul 23, 2024

jakebailey Jul 23, 2024

weswigham Jul 23, 2024

weswigham Jul 23, 2024

weswigham Jul 23, 2024

jakebailey Jul 23, 2024

typescript-bot commented Jul 23, 2024

tsc

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

tsc

tsserver

startup

typescript-bot commented Jul 23, 2024

weswigham commented Jul 23, 2024

typescript-bot commented Jul 23, 2024 •

edited

Loading

typescript-bot commented Jul 23, 2024

jakebailey commented Jul 23, 2024

DanielRosenwasser commented Jul 24, 2024

Skip markLinkedReferences import elision walk entirely in some common cases #59398

Skip markLinkedReferences import elision walk entirely in some common cases #59398

Conversation

weswigham commented Jul 23, 2024 • edited Loading

weswigham commented Jul 23, 2024

typescript-bot commented Jul 23, 2024 • edited Loading

weswigham Jul 23, 2024

Choose a reason for hiding this comment

jakebailey Jul 23, 2024

Choose a reason for hiding this comment

jakebailey Jul 23, 2024

Choose a reason for hiding this comment

weswigham Jul 23, 2024

Choose a reason for hiding this comment

weswigham Jul 23, 2024

Choose a reason for hiding this comment

weswigham Jul 23, 2024

Choose a reason for hiding this comment

jakebailey Jul 23, 2024

Choose a reason for hiding this comment

typescript-bot commented Jul 23, 2024

tsc

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

typescript-bot commented Jul 23, 2024

tsc

tsserver

startup

typescript-bot commented Jul 23, 2024

weswigham commented Jul 23, 2024

typescript-bot commented Jul 23, 2024 • edited Loading

typescript-bot commented Jul 23, 2024

jakebailey commented Jul 23, 2024

DanielRosenwasser commented Jul 24, 2024

weswigham commented Jul 23, 2024 •

edited

Loading

typescript-bot commented Jul 23, 2024 •

edited

Loading

typescript-bot commented Jul 23, 2024 •

edited

Loading