Source tracking - Arc SQL Server creation and register resource provider #26211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshika898
changed the title
akshika898
force-pushed
the
akshikagupta/dev/arc-resource-creation
branch
from
471097a to
959b352
Compare
| const path = encodeURI(`/subscriptions/${subscription.id}/resourceGroups/${resourceGroup.name}/providers/Microsoft.AzureArcData/sqlServerInstances/${sqlServerName}?api-version=${SQL_ARC_API_VERSION}`); | ||
| const api = await getAzureCoreAPI(); | ||
| const host = api.getProviderMetadataForAccount(account).settings.armResource?.endpoint; | ||
| const response = await api.makeAzureRestRequest<any>(account, subscription, path, azurecore.HttpRequestMethod.GET, undefined, true, host, getDefaultHeader()); |
There was a problem hiding this comment.
There is lot of duplicate code . Refactor code to create a helper function having makeAzureRestRequest and calling it in different methods with params
added 2 commits
March 11, 2025 20:06
…v/arc-resource-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SQL server is not enabled by Arc: