Display Arc resource and assessment links #26214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshika898
commented
Feb 21, 2025
akshika898
commented
- If SQL Server is enabled by Arc, display assessment link if computed.
- If SQL Server is enabled by Arc, display resource link.
- Add info message on user inputs.
- Update summary page.
akshika898
force-pushed
the
akshikagupta/dev/arc-resource-creation
branch
from
471097a to
959b352
Compare
akshika898
force-pushed
the
akshikagupta/dev/display-arc-resource-and-assessment
branch
from
4cbe0da to
e0c61b7
Compare
JyotikaGargg
reviewed
Mar 6, 2025
JyotikaGargg
reviewed
Mar 6, 2025
| @@ -209,6 +209,7 @@ export class MigrationStateModel implements Model, vscode.Disposable { | |||
| public _arcResourceResourceGroup!: azurecore.azureResource.AzureResourceResourceGroup; | |||
| public _sourceArcSqlServers!: ArcSqlServer[]; | |||
| public _arcSqlServer!: ArcSqlServer; | |||
| public _arcRpRegistrationStatus!: number; | |||
There was a problem hiding this comment.
We have taken this as number . What if status comes "undefined" or "null" in any case. Does this type cast ?
There was a problem hiding this comment.
Status cannot be null or undefined. In case the API throws error it goes to catch block.
added 2 commits
March 11, 2025 18:21
…ta/dev/display-arc-resource-and-assessment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.