Skip to content

Add a direct reference to JSON schema #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

Add a direct reference to JSON schema #185

merged 1 commit into from
Apr 13, 2021

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Mar 31, 2021

Fixes #61

@vadimcn vadimcn changed the title Update specification.md Add a direct reference to JSON schema Apr 3, 2021
Takangcwele
Takangcwele approved these changes Apr 4, 2021
View reviewed changes
Copy link

@Takangcwele Takangcwele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tee

@Takangcwele Takangcwele mentioned this pull request Apr 4, 2021
Closed
@weinand weinand added this to the April 2021 milestone Apr 12, 2021
@weinand weinand self-assigned this Apr 12, 2021
@weinand weinand merged commit e006fb6 into microsoft:gh-pages Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@microsoft microsoft deleted a comment from Takangcwele Apr 13, 2021
@weinand
Copy link
Contributor

weinand commented Apr 13, 2021 •
edited
Loading

@vadimcn after merging your PR, I've noticed (too late) that your fix lives in a machine generated file which gets overridden whenever the spec has changed:

2021-04-13_14-29-23

I've moved the change to the generator program instead.

weinand added a commit that referenced this pull request Apr 13, 2021
@weinand
Move fix for #185 to md generator; fixes #185
04e680c
@vadimcn
Copy link
Contributor Author

vadimcn commented Apr 14, 2021

LOL. That line was loo long to read, obviously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Takangcwele Takangcwele Takangcwele approved these changes

Assignees

@weinand weinand

Labels
None yet
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@vadimcn @weinand @Takangcwele