-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVMe and resource disc testcase fixes #3432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7e4a17
to
bd7d0e2
Compare
f76263a
to
5855bb7
Compare
b402609
to
b29f14e
Compare
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
squirrelsc
reviewed
Nov 12, 2024
cda3e20
to
0756836
Compare
squirrelsc
reviewed
Nov 21, 2024
9374321
to
26b336a
Compare
NVMe and resource disc testcase fixes 1. Added new testcase "Nvme.verify_nvme_function_unpartitioned". 2. NVMe test case fixes for disc controller type NVMe. 3. "Nvme.verify_nvme_fstrim" - use fstrim testfile size based on available space. 4. Resource disc testcases fixes for VMs with Local NVMEs. 5. Added below new methods: a. check_resource_disk_mounted b. get_resource_disks c. get_resource_disk_type d. get_disk_type e. _remove_nvme_os_disk f. _get_os_disk_nvme_device g. _verify_nvme_function
26b336a
to
1d4da4f
Compare
@LiliDeng LGTM |
LiliDeng
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVMe and resource disc testcase fixes
a. check_resource_disk_mounted
b. get_resource_disks
c. get_resource_disk_type
d. get_disk_type
e. _remove_nvme_os_disk
f. _get_os_disk_nvme_device
g. _verify_nvme_function