-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CVM v6 SKUs #3474
Add CVM v6 SKUs #3474
Conversation
@squirrelsc @LiliDeng I don't like this method of hard coding SKU families. I don't understand the original justification for it. Is there a better solution? |
Do you know the Capabilities names for CVM and Stateless? if yes, we can update coed to reply on them. |
31fa7f8
to
c099ce0
Compare
c099ce0
to
436a25b
Compare
CVM v6 SKUs are being added. We should reduce the need to update lists of SKU families by relying on the capabilities.
436a25b
to
f0750ea
Compare
@LiliDeng LGTM |
@kamalca could you please make sure you have tested this change? Thanks. |
I tested SNP and TDX deployment. I am currently running all of my CVM v6 validation with this change and have seen no issues. |
CVM v6 SKUs need to be added to the list of CVM supporting SKUs.