Raise exception when getting timeout for running cmd to detect OS #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Oct 17, 2024
squirrelsc
reviewed
Oct 17, 2024
lubaihua33
force-pushed
the
baihua/fix_timeout
branch
2 times, most recently
from
c3982f9 to
7905b6b
Compare
lubaihua33
force-pushed
the
baihua/fix_timeout
branch
from
7905b6b to
5f04d78
Compare
|
@LiliDeng LGTM |
LiliDeng
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some images, like sciencelogicinc1622565452194, middleware publisher's images, running some basic commands will be time out. This is due to the image not allow to run commands or in bad state.
In _get_detect_string, there are more than 10 commands to detect the OS. If every command gets time out (10 min), the case might last longer than 1 hour.
The case should be go to the end immediately if the system can't run any commands.
In this PR, add timeout=30 for every command in _get_detect_string, and raise an exception when gets timeout to avoid more timeout commands.