Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default behavior for ARM64 machines and skip high-memory VMs #3498

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

0xba1a
Copy link
Contributor

@0xba1a 0xba1a commented Nov 6, 2024

Use df to get the available disk size instead of relying on capability.

Allow Mariner (both 2.0 and 3.0) to use the default kdump config options. Set force_rebuild only on high-mem machines where the crashdump path has to be updated.

Skip testing on high-mem machines for arm64 architecture.

@0xba1a
Copy link
Contributor Author

0xba1a commented Nov 6, 2024

Testing

  • 2.0 ARM64 Image: MicrosoftCBLMariner:cbl-mariner:cbl-mariner-2-arm64:2.20241029.01

    2024-11-06 17:54:53.535[124836087387904][INFO] lisa.RootRunner         KdumpCrash.verify_kdumpcrash_on_random_cpu: PASSED   
    2024-11-06 17:54:53.536[124836087387904][INFO] lisa.RootRunner                   KdumpCrash.verify_kdumpcrash_smp: PASSED   
    2024-11-06 17:54:53.536[124836087387904][INFO] lisa.RootRunner           KdumpCrash.verify_kdumpcrash_single_core: SKIPPED  deployment skipped: ["no available quota found on 'westus3'."], runbook: Environment(name='generated_2', topology='subnet', nodes_raw=None, nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.Ephemeral,DiskType.PremiumSSDLRS,DiskType.StandardSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.UltraSSDLRS,DiskType.PremiumV2SSDLRS,DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.SCSI],network interface: data_path:allowed:False,items:[NetworkDataPath.Sriov,NetworkDataPath.Synthetic], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[arch:Arm64,SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,items:[SecurityProfileType.Standard], encrypt_disk=False, disk_encryption_set_id=''),gen:2],ef:None,NodeSpace(type='requirement')], _original_nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.Ephemeral,DiskType.PremiumSSDLRS,DiskType.StandardSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.UltraSSDLRS,DiskType.PremiumV2SSDLRS,DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.SCSI],network interface: data_path:allowed:False,items:[NetworkDataPath.Sriov,NetworkDataPath.Synthetic], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[arch:Arm64,SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,items:[SecurityProfileType.Standard], encrypt_disk=False, disk_encrypt
    2024-11-06 17:54:53.537[124836087387904][INFO] lisa.RootRunner              KdumpCrash.verify_kdumpcrash_on_cpu32: SKIPPED  skipped: path option is not supported in Mariner-2.0 for ARM64. kdump will not work well on high memory Mariner-2.0 systems
    2024-11-06 17:54:53.537[124836087387904][INFO] lisa.RootRunner test result summary
    2024-11-06 17:54:53.538[124836087387904][INFO] lisa.RootRunner     TOTAL    : 4
    2024-11-06 17:54:53.538[124836087387904][INFO] lisa.RootRunner     QUEUED   : 0
    2024-11-06 17:54:53.539[124836087387904][INFO] lisa.RootRunner     ASSIGNED : 0
    2024-11-06 17:54:53.539[124836087387904][INFO] lisa.RootRunner     RUNNING  : 0
    2024-11-06 17:54:53.540[124836087387904][INFO] lisa.RootRunner     FAILED   : 0
    2024-11-06 17:54:53.540[124836087387904][INFO] lisa.RootRunner     PASSED   : 2
    2024-11-06 17:54:53.540[124836087387904][INFO] lisa.RootRunner     SKIPPED  : 2
  • 2.0 AMD64 Image: MicrosoftCBLMariner:cbl-mariner:cbl-mariner-2-gen2:2.20240829.01

    2024-11-06 18:06:40.979[140038202996480][INFO] lisa.RootRunner ________________________________________
    2024-11-06 18:06:40.979[140038202996480][INFO] lisa.RootRunner         KdumpCrash.verify_kdumpcrash_on_random_cpu: PASSED   
    2024-11-06 18:06:40.979[140038202996480][INFO] lisa.RootRunner                   KdumpCrash.verify_kdumpcrash_smp: PASSED   
    2024-11-06 18:06:40.979[140038202996480][INFO] lisa.RootRunner           KdumpCrash.verify_kdumpcrash_single_core: SKIPPED  deployment skipped: ["no available quota found on 'westus3'."], runbook: Environment(name='generated_2', topology='subnet', nodes_raw=None, nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.PremiumSSDLRS,DiskType.StandardHDDLRS,DiskType.Ephemeral,DiskType.StandardSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS,DiskType.StandardHDDLRS,DiskType.PremiumV2SSDLRS,DiskType.UltraSSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.NVME,DiskControllerType.SCSI],network interface: data_path:allowed:False,items:[NetworkDataPath.Synthetic,NetworkDataPath.Sriov], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[arch:x64,gen:2,SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,items:[SecurityProfileType.SecureBoot,SecurityProfileType.Standard], encrypt_disk=False, disk_encryption_set_id='')],ef:None,NodeSpace(type='requirement')], _original_nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.PremiumSSDLRS,DiskType.StandardHDDLRS,DiskType.Ephemeral,DiskType.StandardSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS,DiskType.StandardHDDLRS,DiskType.PremiumV2SSDLRS,DiskType.UltraSSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.NVME,DiskControllerType.SCSI],network interface: data_path:allowed:False,items:[NetworkDataPath.Synthetic,NetworkDataPath.Sriov], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[arch:x64,gen:2,SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=all
    2024-11-06 18:06:40.979[140038202996480][INFO] lisa.RootRunner              KdumpCrash.verify_kdumpcrash_on_cpu32: PASSED   
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner test result summary
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     TOTAL    : 4
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     QUEUED   : 0
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     ASSIGNED : 0
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     RUNNING  : 0
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     FAILED   : 0
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     PASSED   : 3
    2024-11-06 18:06:40.980[140038202996480][INFO] lisa.RootRunner     SKIPPED  : 1
  • 3.0 ARM64 - MicrosoftCBLMariner:azure-linux-3:azure-linux-3-arm64:3.20241005.01

    2024-11-06 19:06:28.423[133032845764352][INFO] lisa.RootRunner ________________________________________
    2024-11-06 19:06:28.423[133032845764352][INFO] lisa.RootRunner         KdumpCrash.verify_kdumpcrash_on_random_cpu: PASSED   
    2024-11-06 19:06:28.424[133032845764352][INFO] lisa.RootRunner                   KdumpCrash.verify_kdumpcrash_smp: PASSED   
    2024-11-06 19:06:28.424[133032845764352][INFO] lisa.RootRunner           KdumpCrash.verify_kdumpcrash_single_core: SKIPPED  deployment skipped: ["no available quota found on 'westus3'."], runbook: Environment(name='generated_2', topology='subnet', nodes_raw=None, nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.StandardSSDLRS,DiskType.Ephemeral,DiskType.PremiumSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.PremiumV2SSDLRS,DiskType.StandardSSDLRS,DiskType.UltraSSDLRS,DiskType.PremiumSSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.NVME,DiskControllerType.SCSI],network interface: data_path:allowed:False,items:[NetworkDataPath.Sriov,NetworkDataPath.Synthetic], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[gen:2,arch:Arm64,SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,items:[SecurityProfileType.Standard], encrypt_disk=False, disk_encryption_set_id='')],ef:None,NodeSpace(type='requirement')], _original_nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.StandardSSDLRS,DiskType.Ephemeral,DiskType.PremiumSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.PremiumV2SSDLRS,DiskType.StandardSSDLRS,DiskType.UltraSSDLRS,DiskType.PremiumSSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.NVME,DiskControllerType.SCSI],network interface: data_path:allowed:False,items:[NetworkDataPath.Sriov,NetworkDataPath.Synthetic], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[gen:2,arch:Arm64,SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,items:[SecurityP
    2024-11-06 19:06:28.425[133032845764352][INFO] lisa.RootRunner              KdumpCrash.verify_kdumpcrash_on_cpu32: PASSED   
    2024-11-06 19:06:28.425[133032845764352][INFO] lisa.RootRunner test result summary
    2024-11-06 19:06:28.426[133032845764352][INFO] lisa.RootRunner     TOTAL    : 4
    2024-11-06 19:06:28.426[133032845764352][INFO] lisa.RootRunner     QUEUED   : 0
    2024-11-06 19:06:28.426[133032845764352][INFO] lisa.RootRunner     ASSIGNED : 0
    2024-11-06 19:06:28.426[133032845764352][INFO] lisa.RootRunner     RUNNING  : 0
    2024-11-06 19:06:28.427[133032845764352][INFO] lisa.RootRunner     FAILED   : 0
    2024-11-06 19:06:28.427[133032845764352][INFO] lisa.RootRunner     PASSED   : 3
    2024-11-06 19:06:28.427[133032845764352][INFO] lisa.RootRunner     SKIPPED  : 1
  • 3.0 AMD64 - MicrosoftCBLMariner:azure-linux-3:azure-linux-3-gen2:3.20241005.01

    2024-11-06 19:18:04.780[133839578126080][INFO] lisa.RootRunner ________________________________________
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner         KdumpCrash.verify_kdumpcrash_on_random_cpu: PASSED   
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner                   KdumpCrash.verify_kdumpcrash_smp: PASSED   
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner           KdumpCrash.verify_kdumpcrash_single_core: SKIPPED  deployment skipped: ["no available quota found on 'westus3'."], runbook: Environment(name='generated_2', topology='subnet', nodes_raw=None, nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.Ephemeral,DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS,DiskType.StandardHDDLRS,DiskType.UltraSSDLRS,DiskType.PremiumV2SSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.SCSI,DiskControllerType.NVME],network interface: data_path:allowed:False,items:[NetworkDataPath.Synthetic,NetworkDataPath.Sriov], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,items:[SecurityProfileType.SecureBoot,SecurityProfileType.Standard], encrypt_disk=False, disk_encryption_set_id=''),arch:x64,gen:2],ef:None,NodeSpace(type='requirement')], _original_nodes_requirement=[type:requirement,name:,default:False,count:1,core:1,mem:[2048,],disk:has_resource_disk: None,os_disk_type: allowed:True,items:[DiskType.StandardHDDLRS,DiskType.Ephemeral,DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS],os_disk_size: [0,],data_disk_type: allowed:True,items:[DiskType.StandardSSDLRS,DiskType.PremiumSSDLRS,DiskType.StandardHDDLRS,DiskType.UltraSSDLRS,DiskType.PremiumV2SSDLRS],count: [0,],caching: None,iops: [0,],throughput: [0,],size: [0,],max_data_disk_count: [0,],disk_controller_type: allowed:False,items:[DiskControllerType.SCSI,DiskControllerType.NVME],network interface: data_path:allowed:False,items:[NetworkDataPath.Synthetic,NetworkDataPath.Sriov], nic_count:[1,], max_nic_count:[1,], gpu:[0,],f:allowed:True,items:[SecurityProfileSettings(extended_schemas={}, type='Security_Profile', security_profile=allowed:False,item
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner              KdumpCrash.verify_kdumpcrash_on_cpu32: PASSED   
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner test result summary
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner     TOTAL    : 4
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner     QUEUED   : 0
    2024-11-06 19:18:04.781[133839578126080][INFO] lisa.RootRunner     ASSIGNED : 0
    2024-11-06 19:18:04.782[133839578126080][INFO] lisa.RootRunner     RUNNING  : 0
    2024-11-06 19:18:04.782[133839578126080][INFO] lisa.RootRunner     FAILED   : 0
    2024-11-06 19:18:04.782[133839578126080][INFO] lisa.RootRunner     PASSED   : 3
    2024-11-06 19:18:04.782[133839578126080][INFO] lisa.RootRunner     SKIPPED  : 1

@squirrelsc
Copy link
Member

@LiliDeng LGTM

@LiliDeng LiliDeng merged commit 96bc9ad into microsoft:main Nov 7, 2024
23 checks passed
@0xba1a 0xba1a deleted the bala/fix_kdump_tests_in_place branch November 7, 2024 08:16
LiliDeng pushed a commit that referenced this pull request Nov 13, 2024
…3498)

* Add sufficient sized data-disk in kdump test

* Move print_additional_info just before panic

* Use execute_async and remove kill_on_timeout parameter

* Fix linter errors by moving the check into a new internal function

* Remove whitespace

* Use black format

* Allow default behavior for ARM64 machines and skip high-memory VMs

* Fix flake8 error

* Fix linter error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants