-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow default behavior for ARM64 machines and skip high-memory VMs #3498
Merged
LiliDeng
merged 10 commits into
microsoft:main
from
0xba1a-forked:bala/fix_kdump_tests_in_place
Nov 7, 2024
Merged
Allow default behavior for ARM64 machines and skip high-memory VMs #3498
LiliDeng
merged 10 commits into
microsoft:main
from
0xba1a-forked:bala/fix_kdump_tests_in_place
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Nov 6, 2024
Testing
|
@LiliDeng LGTM |
LiliDeng
approved these changes
Nov 7, 2024
LiliDeng
pushed a commit
that referenced
this pull request
Nov 13, 2024
…3498) * Add sufficient sized data-disk in kdump test * Move print_additional_info just before panic * Use execute_async and remove kill_on_timeout parameter * Fix linter errors by moving the check into a new internal function * Remove whitespace * Use black format * Allow default behavior for ARM64 machines and skip high-memory VMs * Fix flake8 error * Fix linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
df
to get the available disk size instead of relying on capability.Allow Mariner (both 2.0 and 3.0) to use the default kdump config options. Set force_rebuild only on high-mem machines where the crashdump path has to be updated.
Skip testing on high-mem machines for arm64 architecture.