Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernation Test case fixes #3532

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

adityagesh
Copy link
Collaborator

@adityagesh adityagesh commented Nov 26, 2024

PR includes 3 commits

  1. Reboot after running hibernation-setup-tool on RHEL
  2. Skip Hibernation on Mariner. It is not supported.
  3. Change use of uptime -s to last command

Uptime -s has two issues.
1. It rounds up the time, hence the boot time may change by 1-2 seconds when querying after hibernation
2. The tool is not consistent across distro's
@adityagesh adityagesh force-pushed the aditya/add_hibernation_requirement branch 2 times, most recently from 9ec8ba9 to f62790b Compare November 26, 2024 05:38
@adityagesh adityagesh force-pushed the aditya/add_hibernation_requirement branch 2 times, most recently from 300204f to f943173 Compare November 26, 2024 06:03
In RHEL, Hibernate-resume fails if it is done immediately
after executing hibernation-setup-tool.
The root cause is yet to be found, adding a sleep(100) also works
but since we do not have an explanation for "why 100 seconds", use
reboot.
@adityagesh adityagesh force-pushed the aditya/add_hibernation_requirement branch from f943173 to c4f3472 Compare November 26, 2024 06:21
@adityagesh adityagesh force-pushed the aditya/add_hibernation_requirement branch from 1e63759 to 1f53585 Compare November 26, 2024 07:44
@LiliDeng LiliDeng merged commit 7ebd9a7 into main Nov 26, 2024
45 checks passed
@LiliDeng LiliDeng deleted the aditya/add_hibernation_requirement branch November 26, 2024 08:27
adityagesh added a commit that referenced this pull request Dec 20, 2024
* Hibernation: Add CBLMariner to Unsupported Distros

* Hibernation: Check last reboot instead of uptime.

Uptime -s has two issues.
1. It rounds up the time, hence the boot time may change by 1-2 seconds when querying after hibernation
2. The tool is not consistent across distro's

* Hibernation RHEL: Reboot after hibernation-setup-install

In RHEL, Hibernate-resume fails if it is done immediately
after executing hibernation-setup-tool.
The root cause is yet to be found, adding a sleep(100) also works
but since we do not have an explanation for "why 100 seconds", use
reboot.

* Hibernation: Update Supported Distros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants