Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve path for download the file by wget. #3549

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

LiliDeng
Copy link
Collaborator

@LiliDeng LiliDeng commented Dec 9, 2024

After this change https://github.com/microsoft/lisa/pull/3505/files#diff-c566c41343c1a6fe4f895dcfef9ad47e016dda9614454e126cb56c9a6f3fdc54R62, I started to see lsvmbus related issues, during investigation found that "$HOME/.local/bin" is not resolved as we expected in self.node.shell.mkdir(self.node.get_pure_path(path), exist_ok=True) of _ensure_download_path
It fails on all distro which install lsvmbus from source.

@LiliDeng LiliDeng requested a review from squirrelsc as a code owner December 9, 2024 15:10
@LiliDeng LiliDeng force-pushed the lildeng/fix_12_9_001 branch from 2d815b5 to 0c2a5a4 Compare December 9, 2024 15:16
@squirrelsc
Copy link
Member

Please provide the reason, why this change is needed, which distro fails.

@LiliDeng
Copy link
Collaborator Author

LiliDeng commented Dec 10, 2024

After this change https://github.com/microsoft/lisa/pull/3505/files#diff-c566c41343c1a6fe4f895dcfef9ad47e016dda9614454e126cb56c9a6f3fdc54R62, I started to see lsvmbus related issues, during investigation found that "$HOME/.local/bin" is not resolved as we expected in self.node.shell.mkdir(self.node.get_pure_path(path), exist_ok=True) of _ensure_download_path
It fails on all distro which install lsvmbus from source.

@LiliDeng LiliDeng merged commit 5833eab into main Dec 10, 2024
45 checks passed
@LiliDeng LiliDeng deleted the lildeng/fix_12_9_001 branch December 10, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants