Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support for Service tool added. #3573

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Windows support for Service tool added. #3573

merged 7 commits into from
Jan 16, 2025

Conversation

SRIKKANTH
Copy link
Collaborator

@SRIKKANTH SRIKKANTH commented Dec 30, 2024 •
edited
Loading

This pull request adds Windows support for the Service tool.

@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch 5 times, most recently from 5678bbc to 2f38007 Compare December 30, 2024 20:05
squirrelsc
squirrelsc reviewed Dec 30, 2024
View reviewed changes
@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch from 9cfc7ab to 727572d Compare January 1, 2025 08:18
@SRIKKANTH SRIKKANTH marked this pull request as ready for review January 1, 2025 08:23
@SRIKKANTH SRIKKANTH requested a review from LiliDeng as a code owner January 1, 2025 08:23
@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch 2 times, most recently from 72582c5 to 30a8249 Compare January 2, 2025 05:55
@SRIKKANTH SRIKKANTH mentioned this pull request Jan 2, 2025
Merged
@squirrelsc
Copy link
Member

@LiliDeng LGTM

@LiliDeng
Copy link
Collaborator

Please fix CI check error @SRIKKANTH

@LiliDeng
Copy link
Collaborator

@SRIKKANTH please rebase latest main, it will fix the CI check error.

@SRIKKANTH
Windows support for the Service tool.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9719cf2 
This pull request adds Windows support for the Service tool.
@SRIKKANTH
Comments addressed
473cd97
@SRIKKANTH
Update service.py
9214822
@SRIKKANTH
Added message to capture reason for not stopping
e571147
@SRIKKANTH
Update service.py
51baf09
@SRIKKANTH
Update service.py
41ebddb
@SRIKKANTH
Update service.py
96b8bfa
@SRIKKANTH SRIKKANTH force-pushed the smyakam/service_tool_29_12_20024 branch from 8e3a7c3 to 96b8bfa Compare January 15, 2025 12:14
@SRIKKANTH
Copy link
Collaborator Author

@SRIKKANTH please rebase latest main, it will fix the CI check error.

Fixed all CI check errors. please complete the PR @LiliDeng

@LiliDeng LiliDeng merged commit 24801fc into main Jan 16, 2025
45 checks passed
@LiliDeng LiliDeng deleted the smyakam/service_tool_29_12_20024 branch January 16, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squirrelsc squirrelsc

@LiliDeng LiliDeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SRIKKANTH @squirrelsc @LiliDeng