Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test log for deployment failures #3596

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

adityagesh
Copy link
Collaborator

At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.

@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch 2 times, most recently from a4635e1 to a5dada8 Compare January 9, 2025 07:14
@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch from a5dada8 to c2accaf Compare January 13, 2025 03:33
@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch from c2accaf to e69a729 Compare January 13, 2025 03:39
@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch from e69a729 to f4f962f Compare January 13, 2025 09:59
@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch 2 times, most recently from a05d963 to 221f2f0 Compare January 15, 2025 05:54
@adityagesh adityagesh marked this pull request as ready for review January 15, 2025 17:05
@adityagesh adityagesh requested a review from LiliDeng as a code owner January 15, 2025 17:05
@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch from 221f2f0 to dafbafc Compare January 17, 2025 03:19
@adityagesh
Copy link
Collaborator Author

@squirrelsc Can we merge this? or do you have more suggestions?

@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch from dafbafc to 7c1166a Compare January 24, 2025 03:42
@squirrelsc
Copy link
Member

@LiliDeng LGTM

@LiliDeng
Copy link
Collaborator

I found when run against this branch, it costs 30 mins - 60 mins longer than using main branch. @adityagesh could you please check this?

At present, test logs are not generated for deployment failures.
This change creates case log for deployment failure with the failure
reason.
@adityagesh adityagesh force-pushed the aditya/log_deployment_failures branch from 7c1166a to fc3dee0 Compare January 27, 2025 05:03
@LiliDeng LiliDeng merged commit fc0a085 into main Jan 27, 2025
45 checks passed
@LiliDeng LiliDeng deleted the aditya/log_deployment_failures branch January 27, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants