Write test log for deployment failures #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
2 times, most recently
from
a4635e1 to
a5dada8
Compare
adityagesh
commented
Jan 9, 2025
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
a5dada8 to
c2accaf
Compare
adityagesh
commented
Jan 13, 2025
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
c2accaf to
e69a729
Compare
squirrelsc
reviewed
Jan 13, 2025
squirrelsc
reviewed
Jan 13, 2025
squirrelsc
reviewed
Jan 13, 2025
squirrelsc
reviewed
Jan 13, 2025
squirrelsc
reviewed
Jan 13, 2025
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
e69a729 to
f4f962f
Compare
squirrelsc
reviewed
Jan 13, 2025
squirrelsc
reviewed
Jan 13, 2025
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
2 times, most recently
from
a05d963 to
221f2f0
Compare
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
221f2f0 to
dafbafc
Compare
|
@squirrelsc Can we merge this? or do you have more suggestions? |
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
dafbafc to
7c1166a
Compare
|
@LiliDeng LGTM |
|
I found when run against this branch, it costs 30 mins - 60 mins longer than using main branch. @adityagesh could you please check this? |
At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.
adityagesh
force-pushed
the
aditya/log_deployment_failures
branch
from
7c1166a to
fc3dee0
Compare
LiliDeng
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, test logs are not generated for deployment failures. This change creates case log for deployment failure with the failure reason.