hyperv: cleanup stale vm before raising exception #3696
Merged
+40
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If start_vm() fails due to unassigned IP address, an exception is thrown but it results in a stale VM on the HyperV host. This is inefficient as it continues to consume cpu, memory and storage resource of the host. Hence, cleanup the VM before raising the exception.
anirudhrb
reviewed
Mar 6, 2025
|
@LiliDeng LGTM |
LiliDeng
approved these changes
Mar 7, 2025
anirudhrb
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If start_vm() fails due to unassigned IP address, an exception is thrown but it results in a stale VM on the HyperV host. This is inefficient as it continues to consume cpu, memory and storage resource of the host. Hence, cleanup the VM before raising the exception.