NIC passthrough perf test #3706

smit-gardhariya · 2025-03-11T11:19:17Z

Add support to create libvirt device pool from BDF list
Add NIC perf test for passthrough scenario

For device passthrough case, some test need specific PCI device to be run with. Vendor/Device id based pool might assign unwanted devices if many devices are present. Addind support to pass bdf list to create pool here. Signed-off-by: Smit Gardhariya <sgardhariya@microsoft.com>

Add suuport to run iperf3 server with specific IP. Signed-off-by: Smit Gardhariya <sgardhariya@microsoft.com>

Add support to run netperf server/client with specific IP. Signed-off-by: Smit Gardhariya <sgardhariya@microsoft.com>

microsoft/testsuites/performance/networkperf.py

squirrelsc · 2025-03-11T16:16:25Z

microsoft/testsuites/performance/networkperf.py

+        self,
+        node: Node,
+    ) -> Tuple[RemoteNode, str]:
+        ctx = get_node_context(node)


Avoid to use context in test cases, use features to operate nodes, so it's easy to support multiple platforms, and decouple cases and platforms.
So, use the NetworkInterface feature, add a method like enable_passthrough.

Sure, Will make this change

microsoft/testsuites/performance/networkperf.py

lisa/tools/netperf.py

pupacha · 2025-03-12T12:30:17Z

lisa/tools/iperf3.py

@@ -135,6 +136,8 @@ def run_as_server_async(
            cmd += f" -f {report_unit} "
        if port:
            cmd += f" -p {port} "
+        if interface_ip:
+            cmd += f" -B {interface_ip}"


Could you explain what does -B exactly do ?
Something like server_ip is passed from the client while running the iperf tool. What does the new interface_ip additional do here ?

@purna It will run the command and use dedicated interface passed with -B

One server might have multiple interface and we want to run with dedicated passthrough NIC IP

pupacha · 2025-03-12T12:34:48Z

microsoft/testsuites/performance/common.py

@@ -207,6 +207,7 @@ def perf_tcp_pps(
    test_type: str,
    server: Optional[RemoteNode] = None,
    client: Optional[RemoteNode] = None,
+    run_with_internal_address: bool = False,


use_internal_address would be a better name.

@pupacha Sure will make that change.

Please make this change globally in all files.

microsoft/testsuites/performance/common.py

pupacha · 2025-03-12T12:57:49Z

microsoft/testsuites/performance/common.py

+    if server is not None or client is not None:
+        assert server is not None, "server need to be specified, if client is set"
+        assert client is not None, "client need to be specified, if server is set"


if server or client is sufficient. is not None is redundant.
Same for the assert statements.

@pupacha Agree but it was causing issue with flak8 or mypy validation if i remember correctly. So i put it this way.

Could you post the error message here?

pupacha · 2025-03-12T14:16:07Z

microsoft/testsuites/performance/networkperf_passthrough.py

+        assert passthrough_nic_ip, "Can not find interface IP"
+
+        test_node = cast(RemoteNode, node)
+        test_node.internal_address = passthrough_nic_ip


My understanding is internal_address is a field to store any internal network's IP. For example, on an Azure node, it is IP associated with Vnet and for libvirt platforms, it is IP of virtual net setup that libvirt already has.

A testcase should not change node's internal_address. This attribute ownership has to be just with platform.

@squirrelsc , please correct me if my understanding is wrong.

This is internal address of node only. In passthrough testing, node will have 2 interfaces configured. One is virtio-net and other is with vfio. Any case as of now won't use internal_address attribute for passthrough.

For Nating usecases just like we have for libvirt platform, we can use it but node is getting initialized there having host detail similar for internal_address

I dont think I fully understand it.

TestCase should not change the internal_address or any attribute of the node. It should only be done by platform.
There could be other entities like Notifier, Transformer, Feature that could use internal_address. I agree that its not used anywhere as of now, but we shouldn't change it.

May be we should figure out another way of storing IP assigned with the passthrough-ed NIC. How about having PassthroughNIC as a feature and platform will create the feature based on the passthrough config from runbook.

@anirudhrb @gamora12 Any thoughts on this ?

The feature approach is cleaner. If it works, we should go with that.

Agreed, we can have a feature for this.

It looks like a tool more than a feature. The tool returns passthrough IP, and you can use it for testing. The features are used for platform operations, for example, add a data disk by Azure. The passthrough IP can be got from the VM itself, a tool is enough.

Since, the device assignment to VM is already taken care by the platform (with device pool), the only part left is to fetch the IP etc which are all node operations. I agree, Tool is more applicable here.

pupacha · 2025-03-12T14:40:26Z

microsoft/testsuites/performance/networkperf_passthrough.py

+        server = self._get_host_as_server(variables)
+        client, _ = self._configure_passthrough_nic_for_node(node)
+
+        # Reboot the nodes. Libvirt sometime re-use the nodes.


What do you mean Libvirt sometime re-use the node ?

Rebooting the node will create fresh state conditions. I have seen that is requirements are similar, node is getting re-used.

pupacha · 2025-03-12T14:41:38Z

microsoft/testsuites/performance/networkperf_passthrough.py

+        # Reboot the nodes. Libvirt sometime re-use the nodes.
+        # Try to run the test on fresh state of the nodes
+        client.reboot()
+        server.reboot(time_out=1200)


There is no change happening to host, from the time the test started, so reboot is not needed here.

I have seen some port being occupied issue where we run test with libvirt platform one by one. So, rebooting it will create fresh state of VM.

why would server ports be occupied?
If the tests are doing this, it should be cleanup proper in the after_case section.

microsoft/testsuites/performance/networkperf_passthrough.py

pupacha · 2025-03-12T15:09:26Z

lisa/sut_orchestrator/util/device_pool.py

+                        vendor_id=vendor_id,
+                        device_id=device_id,
+                    )
+                elif isinstance(devices, dict):


Should this be PciAddressIdentifier instead of dict ?

It will be dict when it runbook loads it. PciAddressIdentifier is getting treated as dict.

If thats the case, why use isinstance(d, VendorDeviceIdIdentifier) in line 60 ?

Add testcases for nttcp/iperf3/netperf for NIC device passthrough cases for host-guest and guest-guest scenarios. Signed-off-by: Smit Gardhariya <sgardhariya@microsoft.com>

squirrelsc · 2025-03-12T16:47:59Z

microsoft/testsuites/performance/networkperf_passthrough.py

+        return test_node, interface_name
+
+    def _get_host_as_server(self, variables: Dict[str, Any]) -> RemoteNode:
+        ip = variables.get("baremetal_host_ip", "")


It doesn't need to be baremetal, and the name should specify where the variables used. How about networkperf_peer_xxx?

anirudhrb · 2025-03-18T06:02:29Z

lisa/sut_orchestrator/util/schema.py

+@dataclass
+class PciAddressIdentifier:
+    # list of bdf like 0000:3b:00.0 - <domain>:<bus>:<slot>.<fn>
+    pci_bdf: List[str] = field(default_factory=list)


Identifier should have one BDF. Same as how the VendorDeviceIdIdentifer has one set of (vendor_id, device_id).

anirudhrb · 2025-03-18T06:10:02Z

lisa/sut_orchestrator/libvirt/libvirt_device_pool.py

                pool[iommu_group] = devices
                self.available_host_devices[pool_type] = pool

+    def _get_pci_address_instance(


This should be a constructor in DeviceAddressSchema.

Also, DeviceAddressSchema can be renamed to just DeviceAddress

anirudhrb · 2025-03-18T06:22:09Z

lisa/sut_orchestrator/util/device_pool.py

+                    if len(devices) > 1:
+                        raise LisaException(
+                            "Device Pool does not support more than one "
+                            "vendor/device id list for given pool type"


Do we support one set of vendor id + device id or one list?

smit-gardhariya added 3 commits March 10, 2025 18:37

smit-gardhariya requested review from squirrelsc and LiliDeng as code owners March 11, 2025 11:19

smit-gardhariya force-pushed the sgardhariya/nic_passthrough_perf_test branch from 48b3596 to ba8af94 Compare March 11, 2025 15:01

squirrelsc reviewed Mar 11, 2025

View reviewed changes

microsoft/testsuites/performance/networkperf.py Outdated Show resolved Hide resolved

squirrelsc reviewed Mar 11, 2025

View reviewed changes

microsoft/testsuites/performance/networkperf.py Outdated Show resolved Hide resolved

squirrelsc reviewed Mar 11, 2025

View reviewed changes

microsoft/testsuites/performance/networkperf.py Outdated Show resolved Hide resolved

smit-gardhariya force-pushed the sgardhariya/nic_passthrough_perf_test branch 2 times, most recently from a1a57d3 to 25e82b7 Compare March 12, 2025 12:13

pupacha requested changes Mar 12, 2025

View reviewed changes

smit-gardhariya force-pushed the sgardhariya/nic_passthrough_perf_test branch from 25e82b7 to 9ee8763 Compare March 12, 2025 15:59

squirrelsc reviewed Mar 12, 2025

View reviewed changes

anirudhrb suggested changes Mar 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NIC passthrough perf test #3706

NIC passthrough perf test #3706

smit-gardhariya commented Mar 11, 2025

squirrelsc Mar 11, 2025 •

edited

Loading

smit-gardhariya Mar 12, 2025

pupacha Mar 12, 2025

smit-gardhariya Mar 12, 2025 •

edited

Loading

smit-gardhariya Mar 12, 2025

pupacha Mar 12, 2025

smit-gardhariya Mar 12, 2025

smit-gardhariya Mar 12, 2025

pupacha Mar 13, 2025

pupacha Mar 12, 2025

smit-gardhariya Mar 12, 2025

pupacha Mar 13, 2025

pupacha Mar 12, 2025

smit-gardhariya Mar 12, 2025

pupacha Mar 13, 2025

pupacha Mar 13, 2025

anirudhrb Mar 13, 2025

gamora12 Mar 17, 2025

squirrelsc Mar 17, 2025

pupacha Mar 18, 2025

pupacha Mar 12, 2025

smit-gardhariya Mar 12, 2025

pupacha Mar 12, 2025 •

edited

Loading

smit-gardhariya Mar 12, 2025

pupacha Mar 13, 2025

pupacha Mar 12, 2025

smit-gardhariya Mar 12, 2025

pupacha Mar 13, 2025

squirrelsc Mar 12, 2025 •

edited

Loading

anirudhrb Mar 18, 2025

anirudhrb Mar 18, 2025

anirudhrb Mar 18, 2025

NIC passthrough perf test #3706

Are you sure you want to change the base?

NIC passthrough perf test #3706

Conversation

smit-gardhariya commented Mar 11, 2025

squirrelsc Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smit-gardhariya Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pupacha Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

squirrelsc Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

squirrelsc Mar 11, 2025 •

edited

Loading

smit-gardhariya Mar 12, 2025 •

edited

Loading

pupacha Mar 12, 2025 •

edited

Loading

squirrelsc Mar 12, 2025 •

edited

Loading