Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase buffer size for conpty named pipes #765

Closed
deepak1556 opened this issue Mar 10, 2025 · 2 comments · Fixed by #770
Closed

increase buffer size for conpty named pipes #765

deepak1556 opened this issue Mar 10, 2025 · 2 comments · Fixed by #770
Assignees
@deepak1556 @Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows
Milestone
March 2025

Comments

@deepak1556
Copy link
Contributor

No description provided.

@deepak1556 deepak1556 self-assigned this Mar 10, 2025
@deepak1556 deepak1556 added this to the March 2025 milestone Mar 10, 2025
@Tyriar Tyriar mentioned this issue Mar 12, 2025
Closed
Tyriar added a commit that referenced this issue Mar 15, 2025
@Tyriar
Change buffer size to 128KiB
001d5c2 
Part of #765
@Tyriar Tyriar self-assigned this Mar 15, 2025
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 15, 2025
@Tyriar Tyriar mentioned this issue Mar 15, 2025
Merged
@Tyriar Tyriar added the windows label Mar 15, 2025
@Tyriar Tyriar closed this as completed in d9f659b Mar 17, 2025
@rzhao271
Copy link
Contributor

PR LGTM.
Any other steps to verify this issue?

@rzhao271 rzhao271 added verified Verification succeeded verification-steps-needed Steps to verify are needed for verification labels Mar 26, 2025
@Tyriar Tyriar removed the verification-steps-needed Steps to verify are needed for verification label Mar 27, 2025
@Tyriar
Copy link
Member

Tyriar commented Mar 27, 2025

No steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded windows
Projects
None yet
Milestone
March 2025
Development

Successfully merging a pull request may close this issue.

Change conpty named pipe buffer size to 128KiB microsoft/node-pty
3 participants
@deepak1556 @Tyriar @rzhao271