Add missing shebang to the demo Electron app #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jun 8, 2020
`npm_install.sh` cannot execute successfully without a bash/shell shebang (https://en.wikipedia.org/wiki/Shebang_(Unix)) at the beginning of the script. This change adds the missing shebang.
Tyriar
approved these changes
Jun 8, 2020
Thanks for the response. I added the shebang for consistency mainly, as the script is executable and that's how it's presented in the README as well. |
xiaobaidadada
pushed a commit
to xiaobaidadada/node-pty-prebuilt
that referenced
this pull request
Feb 25, 2025
Add missing shebang to the demo Electron app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm_install.shcannot execute successfully without a bash/shell shebang at the beginning of the script.This change adds the missing shebang to the demo Electron app.
Questions
I did not find a CONTRIBUTING md file, I apologize if this PR should've been done differently.